Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(584)

Unified Diff: rlz/lib/rlz_value_store.h

Issue 11308196: [cros] RlzValueStore made protected by a cross-process lock and not persisted over browser lifetime… (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: merge Created 8 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « rlz/lib/rlz_lib_test.cc ('k') | rlz/mac/lib/rlz_value_store_mac.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: rlz/lib/rlz_value_store.h
diff --git a/rlz/lib/rlz_value_store.h b/rlz/lib/rlz_value_store.h
index 807f10000f6c05127066da0b6dab3ffd29d54844..46e87df3331e75323d827a694cb3a7a176ada9b1 100644
--- a/rlz/lib/rlz_value_store.h
+++ b/rlz/lib/rlz_value_store.h
@@ -95,12 +95,7 @@ class ScopedRlzValueStoreLock {
RlzValueStore* GetStore();
private:
-#if defined(OS_WIN) || defined(OS_MACOSX)
- // On ChromeOS, there is a singleton instance of RlzValueStore.
scoped_ptr<RlzValueStore> store_;
-#elif defined(OS_CHROMEOS)
- class RlzValueStoreChromeOS* store_;
-#endif
#if defined(OS_WIN)
LibMutex lock_;
#elif defined(OS_MACOSX)
@@ -108,20 +103,15 @@ class ScopedRlzValueStoreLock {
#endif
};
-#if defined(OS_MACOSX) || defined(OS_CHROMEOS)
+#if defined(OS_POSIX)
namespace testing {
// Prefix |directory| to the path where the RLZ data file lives, for tests.
void SetRlzStoreDirectory(const FilePath& directory);
-} // namespace testing
-#endif // defined(OS_MACOSX) || defined(OS_CHROMEOS)
-#if defined(OS_MACOSX)
-namespace testing {
-// Returns the path of the plist file used as data store.
-std::string RlzPlistFilenameStr();
+// Returns the path of the file used as data store.
+std::string RlzStoreFilenameStr();
} // namespace testing
-#endif // defined(OS_MACOSX)
-
+#endif // defined(OS_POSIX)
} // namespace rlz_lib
« no previous file with comments | « rlz/lib/rlz_lib_test.cc ('k') | rlz/mac/lib/rlz_value_store_mac.mm » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698