Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(70)

Issue 11308182: Prepare push to trunk. Now working on version 3.15.6. (Closed)

Created:
8 years, 1 month ago by ulan
Modified:
8 years, 1 month ago
Reviewers:
Jakob Kummerow
CC:
v8-dev
Visibility:
Public.

Description

Prepare push to trunk. Now working on version 3.15.6. R=jkummerow@chromium.org BUG= Committed: https://code.google.com/p/v8/source/detail?r=13043

Patch Set 1 #

Total comments: 8

Patch Set 2 : address comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -1 line) Patch
M ChangeLog View 1 1 chunk +10 lines, -0 lines 0 comments Download
M src/version.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
ulan
8 years, 1 month ago (2012-11-23 14:25:02 UTC) #1
Jakob Kummerow
LGTM with comments https://chromiumcodereview.appspot.com/11308182/diff/1/ChangeLog File ChangeLog (right): https://chromiumcodereview.appspot.com/11308182/diff/1/ChangeLog#newcode3 ChangeLog:3: Forced small array literals to have ...
8 years, 1 month ago (2012-11-23 14:28:25 UTC) #2
ulan
8 years, 1 month ago (2012-11-23 14:32:55 UTC) #3
Uploaded new patch set, landing.

https://chromiumcodereview.appspot.com/11308182/diff/1/ChangeLog
File ChangeLog (right):

https://chromiumcodereview.appspot.com/11308182/diff/1/ChangeLog#newcode3
ChangeLog:3: Forced small array literals to have FAST_ELEMENTs
On 2012/11/23 14:28:25, Jakob wrote:
> drop this

Done.

https://chromiumcodereview.appspot.com/11308182/diff/1/ChangeLog#newcode8
ChangeLog:8: Reset progress bar of object to 0 when RecordWrites changes object
On 2012/11/23 14:28:25, Jakob wrote:
> drop this

Done.

https://chromiumcodereview.appspot.com/11308182/diff/1/ChangeLog#newcode11
ChangeLog:11: Reverted r13025 and r13026 (they introduced a bug on arm and
regressed
On 2012/11/23 14:28:25, Jakob wrote:
> drop this

Done.

https://chromiumcodereview.appspot.com/11308182/diff/1/ChangeLog#newcode14
ChangeLog:14: Object.observe: Unblacklist some tests involving indexed
properties
On 2012/11/23 14:28:25, Jakob wrote:
> drop this

Done.

Powered by Google App Engine
This is Rietveld 408576698