base/time_posix.cc: Use time64_t on Android.

base/time_posix.cc: Use time64_t on Android.

Android's time_t is 32-bit by default, but the platform provides
a <time64.h> providing for time64_t and associated functions.

Use time64_t in base/time_posix.cc to implement base::Time::Exploded
conversion routines. This avoids un-necessary clamping of the year
to the 1901-2038 range when calling base::Time::Explode() or
base::Time::FromExploded().

BUG=162007
NOTRY=true

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=170738

[digit1, 2012-11-29 13:49:30]

https://chromiumcodereview.appspot.com/11308176/diff/1/base/time_posix.cc
File base/time_posix.cc (right):

https://chromiumcodereview.appspot.com/11308176/diff/1/base/time_posix.cc#new...
base/time_posix.cc:97: struct SysTimeT {
A small comment here: I'm not really sure that a name like SysTimeT is the most
appropriate, but I wanted to avoid using simple "TimeT" because it's very easy
to mistake for "Time".

Also, this is a struct to let users access the 't' field freely, but if you
prefer a private 't_' with an accessor and assignment method, I'd gladly do
this.

Thanks.

[brettw, 2012-11-29 19:27:52]

https://chromiumcodereview.appspot.com/11308176/diff/1/base/time_posix.cc
File base/time_posix.cc (right):

https://chromiumcodereview.appspot.com/11308176/diff/1/base/time_posix.cc#new...
base/time_posix.cc:94: // Define a system-specific SysTimeT that wraps either to
a time_t or
This should go in an anon. namespace at the top of the file.

I'm not sure that the class here does much to help (especially since this is
just local to the file). Maybe just typedef SysTimeT to the appropriate TimeT,
and then write SysTimeToTimeStruct and TimeStructToSysTime functions? It seems
like that would be less boilerplate and just as easy to understand.

[digit1, 2012-11-30 14:10:14]

https://chromiumcodereview.appspot.com/11308176/diff/1/base/time_posix.cc
File base/time_posix.cc (right):

https://chromiumcodereview.appspot.com/11308176/diff/1/base/time_posix.cc#new...
base/time_posix.cc:94: // Define a system-specific SysTimeT that wraps either to
a time_t or
Thanks, that makes sense. Done.

[brettw, 2012-11-30 20:52:33]

lgtm

[commit-bot: I haz the power, 2012-11-30 21:42:02]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/digit@chromium.org/11308176/1002

[commit-bot: I haz the power, 2012-11-30 21:59:55]

Retried try job too often on win for step(s) compile

[commit-bot: I haz the power, 2012-12-03 13:44:02]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/digit@chromium.org/11308176/1002

[commit-bot: I haz the power, 2012-12-03 14:42:21]

Retried try job too often on linux_rel for step(s) ash_unittests

[commit-bot: I haz the power, 2012-12-03 15:05:45]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/digit@chromium.org/11308176/1002

[commit-bot: I haz the power, 2012-12-03 15:06:13]

Change committed as 170738