Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(672)

Issue 11308129: Fix usage of bash builtin "local" in update_depot_tools. (Closed)

Created:
8 years, 1 month ago by newt (away)
Modified:
8 years ago
CC:
chromium-reviews, Dirk Pranke, cmp+cc_chromium.org, M-A Ruel
Visibility:
Public.

Description

Fix usage of bash builtin "local" in update_depot_tools. The bash command "local myvar=$(mycommand)" has the exit status of the bash builtin "local" rather than the exit status of mycommand. To get the exit status of mycommand, "local myvar" should be run separately on a previous line. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=169446

Patch Set 1 #

Total comments: 2

Patch Set 2 : remove comma #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -5 lines) Patch
M update_depot_tools View 1 3 chunks +8 lines, -5 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
newt (away)
8 years, 1 month ago (2012-11-20 20:32:18 UTC) #1
newt (away)
PTAL
8 years, 1 month ago (2012-11-20 20:33:57 UTC) #2
nsylvain
redirecting review to szager or cmp
8 years, 1 month ago (2012-11-20 20:35:38 UTC) #3
szager1
https://codereview.chromium.org/11308129/diff/1/update_depot_tools File update_depot_tools (right): https://codereview.chromium.org/11308129/diff/1/update_depot_tools#newcode75 update_depot_tools:75: local REBASE_TXT, STATUS No comma
8 years, 1 month ago (2012-11-20 21:40:19 UTC) #4
newt (away)
https://codereview.chromium.org/11308129/diff/1/update_depot_tools File update_depot_tools (right): https://codereview.chromium.org/11308129/diff/1/update_depot_tools#newcode75 update_depot_tools:75: local REBASE_TXT, STATUS On 2012/11/20 21:40:19, szager1 wrote: > ...
8 years, 1 month ago (2012-11-20 21:56:44 UTC) #5
Isaac (away)
lgtm but needs owner approval
8 years ago (2012-11-25 04:51:54 UTC) #6
M-A Ruel
rubberstamp lgtm
8 years ago (2012-11-26 16:03:41 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/newt@chromium.org/11308129/2002
8 years ago (2012-11-26 17:49:02 UTC) #8
commit-bot: I haz the power
8 years ago (2012-11-26 17:51:16 UTC) #9
Message was sent while issue was closed.
Change committed as 169446

Powered by Google App Engine
This is Rietveld 408576698