Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(407)

Issue 11308115: Add env variable in gclient recurse with repo path (Closed)

Created:
8 years, 1 month ago by Isaac (away)
Modified:
8 years ago
Reviewers:
cmp, navabi, M-A Ruel
CC:
chromium-reviews, Dirk Pranke, cmp+cc_chromium.org, M-A Ruel
Visibility:
Public.

Description

Add env variable in gclient recurse with repo path - This will be used by navabi to have his gclient recurse command print the current repo. R=maruel@chromium.org BUG= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=169812

Patch Set 1 #

Total comments: 2

Patch Set 2 : change to GCLIENT_DEP_PATH and added doc #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M gclient.py View 1 2 chunks +3 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Isaac (away)
8 years, 1 month ago (2012-11-20 02:30:25 UTC) #1
Isaac (away)
ping
8 years ago (2012-11-26 23:52:06 UTC) #2
M-A Ruel
Wouha, totally missed it, sorry. lgtm anyhow, I don't mind the name much as long ...
8 years ago (2012-11-27 15:09:25 UTC) #3
Isaac (away)
Added help, fixed nit. Committing. https://chromiumcodereview.appspot.com/11308115/diff/1/gclient.py File gclient.py (right): https://chromiumcodereview.appspot.com/11308115/diff/1/gclient.py#newcode644 gclient.py:644: env['GCLIENT_REPO_PATH'] = self.name On ...
8 years ago (2012-11-28 01:29:49 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ilevy@chromium.org/11308115/5001
8 years ago (2012-11-28 01:30:09 UTC) #5
commit-bot: I haz the power
8 years ago (2012-11-28 01:32:50 UTC) #6
Message was sent while issue was closed.
Change committed as 169812

Powered by Google App Engine
This is Rietveld 408576698