Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(582)

Unified Diff: content/browser/web_contents/interstitial_page_impl.cc

Issue 11308083: Fix the html select tag showing up at the wrong position. This was a regression from r166446. (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: fix win_rel Created 8 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/web_contents/interstitial_page_impl.cc
===================================================================
--- content/browser/web_contents/interstitial_page_impl.cc (revision 168623)
+++ content/browser/web_contents/interstitial_page_impl.cc (working copy)
@@ -250,6 +250,9 @@
// already showing. That would result in bad things (unparented HWND on
// Windows for example) happening.
old_view->Show();
+ // WebContentsView implementations cached a pointer to the interstitial view
+ // when we created it, so set the old original back.
+ web_contents_->GetView()->SetView(old_view);
}
// If the focus was on the interstitial, let's keep it to the page.
« no previous file with comments | « content/browser/renderer_host/render_widget_host_impl.cc ('k') | content/browser/web_contents/web_contents_view_android.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698