chrome/browser/ui/prefs/prefs_tab_helper.cc - Issue 11307005: Improve performance of registering font preferences

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/prefs/prefs_tab_helper.cc

Issue 11307005: Improve performance of registering font preferences (Closed) Base URL: http://git.chromium.org/chromium/src.git@master

Patch Set: Removed redundant enum, left over from earlier version of code. Created 8 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/prefs/prefs_tab_helper.cc

diff --git a/chrome/browser/ui/prefs/prefs_tab_helper.cc b/chrome/browser/ui/prefs/prefs_tab_helper.cc

index 903cb9db07a159696e6323e9bb02e5fab2215af4..387fee801509a024e955230fbbe10efab417d49d 100644

--- a/chrome/browser/ui/prefs/prefs_tab_helper.cc

+++ b/chrome/browser/ui/prefs/prefs_tab_helper.cc

@@ -127,8 +127,9 @@ void RegisterFontFamilyMap(PrefService* prefs, const char* map_name) {

const char* script = prefs::kWebKitScriptsForFontFamilyMaps[i];

std::string pref_name_str = base::StringPrintf("%s.%s", map_name, script);

const char* pref_name = pref_name_str.c_str();

- if (!prefs->FindPreference(pref_name))

- prefs->RegisterStringPref(pref_name, "", PrefService::UNSYNCABLE_PREF);

+ prefs->RegisterStringPrefIfNew(pref_name,

+ "",

+ PrefService::UNSYNCABLE_PREF);

}