Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(260)

Unified Diff: chrome/browser/ui/views/omnibox/omnibox_view_win.cc

Issue 11305002: Support TSF related event handling on NativeTextField (Closed) Base URL: http://git.chromium.org/chromium/src.git@findbar_fix
Patch Set: Address comments Created 8 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/views/omnibox/omnibox_view_win.h ('k') | ui/base/ime/win/tsf_event_router.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/views/omnibox/omnibox_view_win.cc
diff --git a/chrome/browser/ui/views/omnibox/omnibox_view_win.cc b/chrome/browser/ui/views/omnibox/omnibox_view_win.cc
index 3023d56936f297b4cca1991c241b5c8b75dd72c8..62b4c97d279191a424a5f15d4a13cc66a2ef9e77 100644
--- a/chrome/browser/ui/views/omnibox/omnibox_view_win.cc
+++ b/chrome/browser/ui/views/omnibox/omnibox_view_win.cc
@@ -917,17 +917,6 @@ bool OmniboxViewWin::OnAfterPossibleChangeInternal(bool force_text_changed) {
return something_changed;
}
-void OmniboxViewWin::OnTextUpdated() {
- if (ignore_ime_messages_)
- return;
- OnAfterPossibleChangeInternal(true);
- // Call OnBeforePossibleChange function here to get correct diff in next IME
- // update. The Text Services Framework does not provide any notification
- // before entering edit session, therefore we don't have good place to call
- // OnBeforePossibleChange.
- OnBeforePossibleChange();
-}
-
void OmniboxViewWin::OnCandidateWindowCountChanged(size_t window_count) {
ime_candidate_window_open_ = (window_count != 0);
if (ime_candidate_window_open_) {
@@ -940,6 +929,17 @@ void OmniboxViewWin::OnCandidateWindowCountChanged(size_t window_count) {
}
}
+void OmniboxViewWin::OnTextUpdated(const ui::Range& /*composition_range*/) {
+ if (ignore_ime_messages_)
+ return;
+ OnAfterPossibleChangeInternal(true);
+ // Call OnBeforePossibleChange function here to get correct diff in next IME
+ // update. The Text Services Framework does not provide any notification
+ // before entering edit session, therefore we don't have good place to call
+ // OnBeforePossibleChange.
+ OnBeforePossibleChange();
+}
+
gfx::NativeView OmniboxViewWin::GetNativeView() const {
return m_hWnd;
}
« no previous file with comments | « chrome/browser/ui/views/omnibox/omnibox_view_win.h ('k') | ui/base/ime/win/tsf_event_router.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698