Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(996)

Unified Diff: sdk/lib/_internal/compiler/implementation/lib/regexp_helper.dart

Issue 11304021: Add NativeEnqueuer to work with the Enqueuer. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 8 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: sdk/lib/_internal/compiler/implementation/lib/regexp_helper.dart
diff --git a/sdk/lib/_internal/compiler/implementation/lib/regexp_helper.dart b/sdk/lib/_internal/compiler/implementation/lib/regexp_helper.dart
index 42f64939c667c4e28180e546749d0de91dc8d081..7eb22153191408537724edd5dcab899d447934ea 100644
--- a/sdk/lib/_internal/compiler/implementation/lib/regexp_helper.dart
+++ b/sdk/lib/_internal/compiler/implementation/lib/regexp_helper.dart
@@ -23,7 +23,7 @@ regExpGetNative(JSSyntaxRegExp regExp) {
}
regExpAttachGlobalNative(JSSyntaxRegExp regExp) {
- JS('var', r'#._re = #', regExp, regExpMakeNative(regExp, global: true));
+ JS('void', r'#._re = #', regExp, regExpMakeNative(regExp, global: true));
}
regExpMakeNative(JSSyntaxRegExp regExp, {bool global: false}) {
@@ -36,7 +36,7 @@ regExpMakeNative(JSSyntaxRegExp regExp, {bool global: false}) {
if (ignoreCase) sb.add('i');
if (global) sb.add('g');
try {
- return JS('Object', r'new RegExp(#, #)', pattern, sb.toString());
+ return JS('var', r'new RegExp(#, #)', pattern, sb.toString());
} catch (e) {
throw new IllegalJSRegExpException(pattern,
JS('String', r'String(#)', e));

Powered by Google App Engine
This is Rietveld 408576698