Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(785)

Issue 11304020: cc: Nine patch layer. (Closed)

Created:
8 years, 1 month ago by aelias_OOO_until_Jul13
Modified:
8 years, 1 month ago
Reviewers:
danakj, jamesr, jscholler
CC:
chromium-reviews, cc-bugs_chromium.org, darin-cc_chromium.org, no sievers
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Rebase to 165204 #

Patch Set 3 : Rebase to 165291 #

Patch Set 4 : Fixed rebase to 165291 #

Total comments: 10

Patch Set 5 : Add unit tests and address code review #

Total comments: 7

Patch Set 6 : Address code review comments and rebase to 166066 #

Patch Set 7 : Added more comments #

Patch Set 8 : Fix component build #

Patch Set 9 : Reupload for trybots #

Patch Set 10 : Fix DCHECK failures and rebase to 166129 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+741 lines, -65 lines) Patch
M cc/cc.gyp View 1 2 3 4 5 2 chunks +6 lines, -0 lines 0 comments Download
M cc/cc_tests.gyp View 1 2 3 4 5 1 chunk +2 lines, -0 lines 0 comments Download
M cc/image_layer.cc View 1 2 3 4 5 1 chunk +1 line, -65 lines 0 comments Download
A cc/image_layer_updater.h View 1 2 1 chunk +50 lines, -0 lines 0 comments Download
A cc/image_layer_updater.cc View 1 2 3 1 chunk +55 lines, -0 lines 0 comments Download
A cc/nine_patch_layer.h View 1 2 3 4 5 6 7 1 chunk +55 lines, -0 lines 0 comments Download
A cc/nine_patch_layer.cc View 1 2 3 4 5 6 7 8 9 1 chunk +99 lines, -0 lines 0 comments Download
A cc/nine_patch_layer_impl.h View 1 2 3 4 5 6 7 1 chunk +51 lines, -0 lines 0 comments Download
A cc/nine_patch_layer_impl.cc View 1 2 3 4 5 6 1 chunk +117 lines, -0 lines 0 comments Download
A cc/nine_patch_layer_impl_unittest.cc View 1 2 3 4 5 6 7 8 9 1 chunk +94 lines, -0 lines 0 comments Download
A cc/nine_patch_layer_unittest.cc View 1 2 3 4 5 6 7 8 9 1 chunk +142 lines, -0 lines 0 comments Download
M webkit/compositor_bindings/compositor_bindings.gyp View 1 2 3 4 5 1 chunk +2 lines, -0 lines 0 comments Download
A webkit/compositor_bindings/web_nine_patch_layer_impl.h View 1 chunk +31 lines, -0 lines 0 comments Download
A webkit/compositor_bindings/web_nine_patch_layer_impl.cc View 1 2 3 4 1 chunk +36 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (0 generated)
aelias_OOO_until_Jul13
This is a rebased/restyled version of 10963056 that also shares ImageLayerUpdater instead of introducing a ...
8 years, 1 month ago (2012-10-26 23:52:00 UTC) #1
aelias_OOO_until_Jul13
James, do you think we might be able to land this? Jerome is relying on ...
8 years, 1 month ago (2012-11-01 05:22:03 UTC) #2
jamesr
The appendQuads() function is quite dense and has a lot of specialized UI logic. Could ...
8 years, 1 month ago (2012-11-01 19:55:42 UTC) #3
aelias_OOO_until_Jul13
OK, all done. Daniel's patch actually had unit tests, I just was waiting to make ...
8 years, 1 month ago (2012-11-02 07:38:03 UTC) #4
aelias_OOO_until_Jul13
https://codereview.chromium.org/11304020/diff/7001/cc/nine_patch_layer.cc File cc/nine_patch_layer.cc (right): https://codereview.chromium.org/11304020/diff/7001/cc/nine_patch_layer.cc#newcode94 cc/nine_patch_layer.cc:94: if (m_resource.get()) On 2012/11/01 19:55:43, jamesr wrote: > does ...
8 years, 1 month ago (2012-11-02 07:38:16 UTC) #5
danakj
https://codereview.chromium.org/11304020/diff/7001/cc/nine_patch_layer.cc File cc/nine_patch_layer.cc (right): https://codereview.chromium.org/11304020/diff/7001/cc/nine_patch_layer.cc#newcode94 cc/nine_patch_layer.cc:94: if (m_resource.get()) On 2012/11/02 07:38:16, aelias wrote: > On ...
8 years, 1 month ago (2012-11-02 16:04:14 UTC) #6
jamesr
lgtm - test could probably be a little more robust but otherwise looks fine. http://codereview.chromium.org/11304020/diff/3002/cc/nine_patch_layer.cc ...
8 years, 1 month ago (2012-11-05 23:10:53 UTC) #7
aelias_OOO_until_Jul13
All done. https://codereview.chromium.org/11304020/diff/7001/cc/nine_patch_layer.cc File cc/nine_patch_layer.cc (right): https://codereview.chromium.org/11304020/diff/7001/cc/nine_patch_layer.cc#newcode94 cc/nine_patch_layer.cc:94: if (m_resource.get()) On 2012/11/02 16:04:14, danakj wrote: ...
8 years, 1 month ago (2012-11-06 01:15:00 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/aelias@chromium.org/11304020/13003
8 years, 1 month ago (2012-11-06 01:16:27 UTC) #9
commit-bot: I haz the power
Failed to apply the patch.
8 years, 1 month ago (2012-11-06 01:37:31 UTC) #10
commit-bot: I haz the power
Failed to apply the patch.
8 years, 1 month ago (2012-11-06 01:39:08 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/aelias@chromium.org/11304020/8041
8 years, 1 month ago (2012-11-06 03:46:03 UTC) #12
commit-bot: I haz the power
Change committed as 166154
8 years, 1 month ago (2012-11-06 05:53:01 UTC) #13
jscholler
8 years, 1 month ago (2012-11-06 15:14:38 UTC) #14
Thanks!


On Mon, Nov 5, 2012 at 9:53 PM, <commit-bot@chromium.org> wrote:

> Change committed as 166154
>
>
https://chromiumcodereview.**appspot.com/11304020/<https://chromiumcodereview...
>

Powered by Google App Engine
This is Rietveld 408576698