[cros] Prevent extensions from opening dialogs on Login screen.

[cros] Prevent extensions from opening dialogs on Login screen.


BUG=chrome-os-partner:13898
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=164806

[Ivan Korotkov, 2012-10-29 12:58:26]

Hi Aaron, could you please take a look?

[Aaron Boodman, 2012-10-29 15:52:59]

Weird layering to have this class know so much about the context it is used in.
Can you expose a setter instead and push this information down from higher
layers?

[Ivan Korotkov, 2012-10-29 16:11:09]

Looking at ExtensionHostManager, it seems that a new ExtensionHost instance is
created for each extension's background page/action page, right?

So this will require adding an ExtensionHostObserver, that is notified about
ExtensionHost creation, and UserManager will tell each new instance to disallow
dialogs, and then after session start tell them back to allow dialogs. Or is
there a simpler way?

We need some trivial change here, as we want to merge it to M23. We can actually
revert this change soon after merging, because on ToT spawning of modal dialogs
during screen lock should be fixed in Aura soon.

[Nikita (slow), 2012-10-29 18:52:22]

On 2012/10/29 16:11:09, Ivan Korotkov wrote:
> We need some trivial change here, as we want to merge it to M23. We can
actually
> revert this change soon after merging, because on ToT spawning of modal
dialogs
> during screen lock should be fixed in Aura soon.

Correct, I have an upcoming change that will address this case as well so this
fix is only for M23 scope where multiple fixes for modal dialog handling in Ash
are complicated by refactoring done on trunk.

[Aaron Boodman, 2012-10-29 19:12:54]

OK, temporary change LGTM

[commit-bot: I haz the power, 2012-10-29 19:15:14]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/ivankr@chromium.org/11301016/1

[commit-bot: I haz the power, 2012-10-29 21:07:48]

Retried try job too often for step(s) content_browsertests

[commit-bot: I haz the power, 2012-10-29 21:32:26]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/ivankr@chromium.org/11301016/1

[commit-bot: I haz the power, 2012-10-30 01:07:16]

Change committed as 164806