Chromium Code Reviews
Help | Chromium Project | Sign in
(28)

Issue 11301016: [cros] Prevent extensions from opening dialogs on Login screen. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
1 year, 5 months ago by Ivan Korotkov
Modified:
1 year, 5 months ago
Reviewers:
Aaron Boodman
CC:
chromium-reviews_chromium.org, chromium-apps-reviews_chromium.org
Visibility:
Public.

Description

[cros] Prevent extensions from opening dialogs on Login screen.


BUG=chrome-os-partner:13898
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=164806

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -0 lines) Lint Patch
M chrome/browser/extensions/extension_host.h View 1 chunk +3 lines, -0 lines 0 comments 0 errors Download
M chrome/browser/extensions/extension_host.cc View 2 chunks +12 lines, -0 lines 0 comments 1 errors Download
Commit:

Messages

Total messages: 9
Ivan Korotkov
Hi Aaron, could you please take a look?
1 year, 5 months ago #1
Aaron Boodman
Weird layering to have this class know so much about the context it is used ...
1 year, 5 months ago #2
Ivan Korotkov
Looking at ExtensionHostManager, it seems that a new ExtensionHost instance is created for each extension's ...
1 year, 5 months ago #3
Nikita Kostylev
On 2012/10/29 16:11:09, Ivan Korotkov wrote: > We need some trivial change here, as we ...
1 year, 5 months ago #4
Aaron Boodman
OK, temporary change LGTM
1 year, 5 months ago #5
I haz the power (commit-bot)
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ivankr@chromium.org/11301016/1
1 year, 5 months ago #6
I haz the power (commit-bot)
Retried try job too often for step(s) content_browsertests
1 year, 5 months ago #7
I haz the power (commit-bot)
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ivankr@chromium.org/11301016/1
1 year, 5 months ago #8
I haz the power (commit-bot)
1 year, 5 months ago #9
Change committed as 164806
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 1275:d14800f88434