Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Issue 11301003: Specify dependences correctly when building mac tools for iOS. (Closed)

Created:
8 years, 1 month ago by blundell
Modified:
8 years, 1 month ago
CC:
chromium-reviews
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Specify dependences correctly when building mac tools for iOS. Several auxiliary tools used when building Chrome for iOS are generated via the following two-step pattern: (1) compiling the executable with ninja, and (2) copying the executable into a location that is shared with other projects. Previously, these two steps were specified as actions in the same target. However, as the ordering of multiple actions in one target is defined only by inputs and outputs and the compilation action had no inputs/outputs set, the copying action wasn't properly depending on the compilation action. As it's challenging to set correct inputs for the ninja build, this CL separates these actions into two targets in order to be able to specify that the second action should not run until the first action finishes. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=164743

Patch Set 1 #

Patch Set 2 : Fixes #

Patch Set 3 : Response to review #

Patch Set 4 : Second fix #

Patch Set 5 : Remove cruft #

Patch Set 6 : Nit #

Unified diffs Side-by-side diffs Delta from patch set Stats (+179 lines, -106 lines) Patch
M breakpad/breakpad.gyp View 2 chunks +23 lines, -2 lines 0 comments Download
M build/ios/mac_build.gypi View 2 chunks +4 lines, -4 lines 0 comments Download
M testing/iossim/iossim.gyp View 1 2 1 chunk +108 lines, -81 lines 0 comments Download
M third_party/protobuf/protobuf.gyp View 1 2 3 4 5 2 chunks +44 lines, -19 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
blundell
8 years, 1 month ago (2012-10-29 09:58:27 UTC) #1
qsr
I don't like that the dependency to protoc is not the same of ios and ...
8 years, 1 month ago (2012-10-29 10:42:39 UTC) #2
blundell
On 2012/10/29 10:42:39, qsr wrote: > I don't like that the dependency to protoc is ...
8 years, 1 month ago (2012-10-29 16:10:11 UTC) #3
qsr
lgtm
8 years, 1 month ago (2012-10-29 16:41:26 UTC) #4
blundell
+rohitrao for iossim OWNERS. +mark for breakpad OWNERS.
8 years, 1 month ago (2012-10-29 16:51:10 UTC) #5
Mark Mentovai
LGTM for breakpad OWNERS approval.
8 years, 1 month ago (2012-10-29 18:33:53 UTC) #6
rohitrao (ping after 24h)
LGTM for iossim.
8 years, 1 month ago (2012-10-29 18:35:25 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/blundell@chromium.org/11301003/27002
8 years, 1 month ago (2012-10-29 18:56:51 UTC) #8
commit-bot: I haz the power
8 years, 1 month ago (2012-10-29 21:36:37 UTC) #9
Change committed as 164743

Powered by Google App Engine
This is Rietveld 408576698