Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(122)

Issue 11300005: Adding a new transition type flag to Android ContentView. (Closed)

Created:
8 years, 1 month ago by Jay Civelli
Modified:
8 years, 1 month ago
Reviewers:
Agrawal
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam
Visibility:
Public.

Description

Adding a new transition type flag to Android ContentView. The flag PAGE_TRANSITION_FROM_ADDRESS_BAR was missing in Android's ContentView. It is needed for instance for inducing browser crashers in tests. BUG=None TEST=None Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=164316

Patch Set 1 #

Patch Set 2 : Fixed typo. #

Patch Set 3 : Initial patch #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M content/public/android/java/src/org/chromium/content/browser/ContentView.java View 1 2 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Jay Civelli
8 years, 1 month ago (2012-10-25 22:13:15 UTC) #1
nilesh
LGTM with nit
8 years, 1 month ago (2012-10-25 23:42:03 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jcivelli@chromium.org/11300005/3002
8 years, 1 month ago (2012-10-26 00:51:42 UTC) #3
commit-bot: I haz the power
8 years, 1 month ago (2012-10-26 11:21:50 UTC) #4
Change committed as 164316

Powered by Google App Engine
This is Rietveld 408576698