Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(60)

Issue 11299332: Delayload bluetooth imports on Windows. (Closed)

Created:
8 years ago by grt (UTC plus 2)
Modified:
8 years ago
CC:
chromium-reviews
Visibility:
Public.

Description

Delayload bluetooth imports on Windows. Some systems (e.g., Windows Server 2012) do not have a bluetooth stack, so the corresponding dll (bthprops.cpl) isn't present. If neither delayload nor explicit runtime binding is used, then binaries linking in the device_bluetooth target will fail to load on such systems. BUG=135470 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=171353

Patch Set 1 #

Patch Set 2 : moar #

Unified diffs Side-by-side diffs Delta from patch set Stats (+57 lines, -1 line) Patch
M device/bluetooth/bluetooth_adapter_win.cc View 1 2 chunks +44 lines, -1 line 0 comments Download
M device/device.gyp View 1 1 chunk +13 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
grt (UTC plus 2)
robertshield: please review the CL description and content for Windows-fu bryeung: please provider your OWNERShip ...
8 years ago (2012-12-04 15:21:30 UTC) #1
grt (UTC plus 2)
Robert just convinced me that it's more safer if I put in the detection code ...
8 years ago (2012-12-04 15:28:05 UTC) #2
bryeung
Happy to give OWNERS blessing after Youngki has reviewed (he's actually the one implementing the ...
8 years ago (2012-12-04 15:41:39 UTC) #3
grt (UTC plus 2)
Okay, ready for review. Youngki: I left a TODO for you in the code since ...
8 years ago (2012-12-04 18:48:20 UTC) #4
robertshield
lgtm
8 years ago (2012-12-04 19:00:54 UTC) #5
youngki
lgtm Thanks for the CL. I am actually working on creating a dedicated thread to ...
8 years ago (2012-12-05 02:33:08 UTC) #6
bryeung
lgtm
8 years ago (2012-12-05 13:58:44 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/grt@chromium.org/11299332/6001
8 years ago (2012-12-05 19:53:48 UTC) #8
commit-bot: I haz the power
8 years ago (2012-12-05 23:28:03 UTC) #9
Message was sent while issue was closed.
Change committed as 171353

Powered by Google App Engine
This is Rietveld 408576698