Break CloudPolicyRefreshScheduler's dependency on PrefService.

Break CloudPolicyRefreshScheduler's dependency on PrefService.

This is in preparation for refreshing public account policy, which
doesn't have a PrefService at its disposal. CloudPolicyManager now takes
care of extracting the pref value and passing it on to
CloudPolicyRefreshScheduler.

BUG=chromium:152937
TEST=unit tests


Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=170974

[Mattias Nissler (ping if slow), 2012-12-03 16:48:02]

Please review.

[Mattias Nissler (ping if slow), 2012-12-04 11:20:53]

Friendly review ping.

[pastarmovj, 2012-12-04 12:20:38]

lgtm with one nit.

https://codereview.chromium.org/11299305/diff/3001/chrome/browser/policy/clou...
File chrome/browser/policy/cloud_policy_refresh_scheduler_unittest.cc (right):

https://codereview.chromium.org/11299305/diff/3001/chrome/browser/policy/clou...
chrome/browser/policy/cloud_policy_refresh_scheduler_unittest.cc:10: #include
"base/values.h"
Do you need this include?

[bartfab (slow), 2012-12-04 12:25:18]

https://codereview.chromium.org/11299305/diff/3001/chrome/browser/policy/clou...
File chrome/browser/policy/cloud_policy_refresh_scheduler.cc (right):

https://codereview.chromium.org/11299305/diff/3001/chrome/browser/policy/clou...
chrome/browser/policy/cloud_policy_refresh_scheduler.cc:11: #include
"chrome/browser/prefs/pref_service.h"
Nit: No longer needed.

https://codereview.chromium.org/11299305/diff/3001/chrome/browser/policy/clou...
chrome/browser/policy/cloud_policy_refresh_scheduler.cc:52: refresh_delay_ms_ =
refresh_delay;
Why not clamp when setting the value here instead of storing a potentially
invalid value and continuously clamping on-the-fly in the getter?

https://codereview.chromium.org/11299305/diff/3001/chrome/browser/policy/clou...
File chrome/browser/policy/cloud_policy_refresh_scheduler.h (right):

https://codereview.chromium.org/11299305/diff/3001/chrome/browser/policy/clou...
chrome/browser/policy/cloud_policy_refresh_scheduler.h:8: #include <string>
Nit: No longer needed.

https://codereview.chromium.org/11299305/diff/3001/chrome/browser/policy/clou...
chrome/browser/policy/cloud_policy_refresh_scheduler.h:18: class PrefService;
Nit: No longer needed.

[Mattias Nissler (ping if slow), 2012-12-04 13:20:40]

Comments addressed. Ready to go?

https://codereview.chromium.org/11299305/diff/3001/chrome/browser/policy/clou...
File chrome/browser/policy/cloud_policy_refresh_scheduler.cc (right):

https://codereview.chromium.org/11299305/diff/3001/chrome/browser/policy/clou...
chrome/browser/policy/cloud_policy_refresh_scheduler.cc:11: #include
"chrome/browser/prefs/pref_service.h"
On 2012/12/04 12:25:18, bartfab wrote:
> Nit: No longer needed.

Done.

https://codereview.chromium.org/11299305/diff/3001/chrome/browser/policy/clou...
chrome/browser/policy/cloud_policy_refresh_scheduler.cc:52: refresh_delay_ms_ =
refresh_delay;
On 2012/12/04 12:25:18, bartfab wrote:
> Why not clamp when setting the value here instead of storing a potentially
> invalid value and continuously clamping on-the-fly in the getter?

Doesn't matter really, but I guess what you propose makes this simpler. Done.

https://codereview.chromium.org/11299305/diff/3001/chrome/browser/policy/clou...
File chrome/browser/policy/cloud_policy_refresh_scheduler.h (right):

https://codereview.chromium.org/11299305/diff/3001/chrome/browser/policy/clou...
chrome/browser/policy/cloud_policy_refresh_scheduler.h:8: #include <string>
On 2012/12/04 12:25:18, bartfab wrote:
> Nit: No longer needed.

Done.

https://codereview.chromium.org/11299305/diff/3001/chrome/browser/policy/clou...
chrome/browser/policy/cloud_policy_refresh_scheduler.h:18: class PrefService;
On 2012/12/04 12:25:18, bartfab wrote:
> Nit: No longer needed.

Done.

https://codereview.chromium.org/11299305/diff/3001/chrome/browser/policy/clou...
File chrome/browser/policy/cloud_policy_refresh_scheduler_unittest.cc (right):

https://codereview.chromium.org/11299305/diff/3001/chrome/browser/policy/clou...
chrome/browser/policy/cloud_policy_refresh_scheduler_unittest.cc:10: #include
"base/values.h"
On 2012/12/04 12:20:38, pastarmovj wrote:
> Do you need this include?

No, removed.

[bartfab (slow), 2012-12-04 13:46:29]

I see I forgot to say "lgtm with nits". Saying it now - without any nits left
:).

[commit-bot: I haz the power, 2012-12-04 13:53:52]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/mnissler@chromium.org/11299305/1006

[commit-bot: I haz the power, 2012-12-04 16:33:38]

Change committed as 170974