Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2487)

Unified Diff: chrome/renderer/autofill/password_autofill_manager.cc

Issue 11299287: Fixing missing password Autofill popup for Android (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/renderer/autofill/password_autofill_manager.cc
diff --git a/chrome/renderer/autofill/password_autofill_manager.cc b/chrome/renderer/autofill/password_autofill_manager.cc
index 413411ff8e75288381c4a404d1233b6269ec10f2..15386163a79c762ee3fcdf070f9ef57dff195630 100644
--- a/chrome/renderer/autofill/password_autofill_manager.cc
+++ b/chrome/renderer/autofill/password_autofill_manager.cc
@@ -604,8 +604,12 @@ void PasswordAutofillManager::PerformInlineAutocomplete(
// Show the popup with the list of available usernames.
ShowSuggestionPopup(fill_data, username);
- // Fill the user and password field with the most relevant match.
+
+#if !defined(OS_ANDROID)
+ // Fill the user and password field with the most relevant match. Android
+ // only fills in the fields after the user clicks on the suggestion popup.
Ilya Sherman 2012/12/03 23:27:17 Hmm, why does the Android UI differ in this way fr
aurimas (slooooooooow) 2012/12/04 02:05:00 Done.
FillUserNameAndPassword(&username, &password, fill_data, false, true);
+#endif
}
void PasswordAutofillManager::FrameClosing(const WebKit::WebFrame* frame) {

Powered by Google App Engine
This is Rietveld 408576698