Fixing missing password Autofill popup for Android

chrome/browser/autofill/autofill_external_delegate.cc

Index: chrome/browser/autofill/autofill_external_delegate.cc
diff --git a/chrome/browser/autofill/autofill_external_delegate.cc b/chrome/browser/autofill/autofill_external_delegate.cc
index b4fde5dded14bfd7140839ccc2c98317e6142814..8427e554e4b345e956546d87c00c6b7f8b2b52cb 100644
--- a/chrome/browser/autofill/autofill_external_delegate.cc
+++ b/chrome/browser/autofill/autofill_external_delegate.cc
@@ -208,6 +208,7 @@ bool AutofillExternalDelegate::DidAcceptAutofillSuggestions(
                  autofill_query_field_, value)) {
     // DidAcceptAutofillSuggestion has already handled the work to fill in
     // the page as required.
+    popup_visible_ = true;

[Ilya Sherman, 2012/12/03 23:27:17]

Hmm, why is this change needed?  It's not obvious to me that the popup is
guaranteed to be visible at this point, and I'm surprised that popup_visible_
wasn't updated earlier, when the popup actually got shown.

[aurimas (slooooooooow), 2012/12/04 02:05:00]

Done.

   } else if (unique_id == WebAutofillClient::MenuItemIDDataListEntry) {
     host->Send(new AutofillMsg_AcceptDataListSuggestion(host->GetRoutingID(),
                                                         value));