Issue 11299279: Browser Plugin: Simplify BrowserPluginPropertyBinding

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11299279: Browser Plugin: Simplify BrowserPluginPropertyBinding (Closed)

Created:
8 years ago by Fady Samuel

Modified:
8 years ago

Reviewers:
sadrul, lazyboy

CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Browser Plugin: Simplify BrowserPluginPropertyBinding A BrowserPluginPropertyBinding is bound to a particular property name, so there is no point to passing in the property name on GetProperty and SetProperty. BUG=None Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=170528

Patch Set 1 #

Created: 8 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -20 lines)			Patch
	M	content/renderer/browser_plugin/browser_plugin_bindings.cc	View		17 chunks	+2 lines, -20 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/fsamuel@chromium.org/11299279/1

8 years ago (2012-11-30 18:53:43 UTC) #5

Message was sent while issue was closed.

Change committed as 170528

Expand Messages | Collapse Messages