Issue 11299276: Bound the maximum touchscreen fling velocity.

Issue 11299276: Bound the maximum touchscreen fling velocity. (Closed)

Created:
8 years ago by rjkroege

Modified:
8 years ago

Reviewers:
James Hawkins, sadrul, sky

CC:
chromium-reviews, arv (Not doing code reviews), sadrul, ben+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Bound the maximum touchscreen fling velocity. Set a configurable cap on the maximum touchscreen fling velocity. BUG=141653 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=170761

Patch Set 2 : proof-reading nits #

Total comments: 1

Patch Set 3 : review nits #

Created: 8 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+27 lines, -6 lines)			Patch
M	chrome/browser/resources/gesture_config.js	View		1 chunk	+5 lines, -0 lines	0 comments	Download
M	chrome/browser/ui/gesture_prefs_observer_factory_aura.cc	View		3 chunks	+7 lines, -0 lines	0 comments	Download
M	chrome/common/pref_names.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/common/pref_names.cc	View	1 2	1 chunk	+1 line, -0 lines	0 comments	Download
M	ui/aura/test/aura_test_base.cc	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
M	ui/base/gestures/gesture_configuration.h	View		2 chunks	+7 lines, -0 lines	0 comments	Download
M	ui/base/gestures/gesture_configuration.cc	View		1 chunk	+1 line, -5 lines	0 comments	Download
M	ui/base/gestures/gesture_sequence.cc	View	1	1 chunk	+4 lines, -1 line	0 comments	Download

Messages

Total messages: 9 (0 generated)

Expand Messages | Collapse Messages

rjkroege

ptal https://codereview.chromium.org/11299276/diff/1/ui/base/gestures/gesture_configuration.cc File ui/base/gestures/gesture_configuration.cc (left): https://codereview.chromium.org/11299276/diff/1/ui/base/gestures/gesture_configuration.cc#oldcode13 ui/base/gestures/gesture_configuration.cc:13: // TODO(rbyers) unify these - crbug.com/156392 note that ...

8 years ago (2012-11-30 16:03:15 UTC) #1

sadrul

LGTM https://codereview.chromium.org/11299276/diff/1009/chrome/common/pref_names.cc File chrome/common/pref_names.cc (right): https://codereview.chromium.org/11299276/diff/1009/chrome/common/pref_names.cc#newcode2087 chrome/common/pref_names.cc:2087: there's an extra new line here!

8 years ago (2012-11-30 16:59:48 UTC) #2

rjkroege

additional OWNERS review please? jhawkins for OWNERS on chrome/browser/resources/gesture_config.js sky for OWNERS on: chrome/browser/ui/gesture_prefs_observer_factory_aura.cc chrome/common/pref_names.cc ...

8 years ago (2012-11-30 18:23:49 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rjkroege@chromium.org/11299276/5001

8 years ago (2012-12-03 15:01:43 UTC) #6

commit-bot: I haz the power

Retried try job too often on linux_rel for step(s) ash_unittests

8 years ago (2012-12-03 16:53:18 UTC) #7

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rjkroege@chromium.org/11299276/5001

8 years ago (2012-12-03 18:10:19 UTC) #8

Message was sent while issue was closed.

Change committed as 170761

Expand Messages | Collapse Messages