Issue 11299263: Build chromedriver2_unittests as part of chromium_builder_tests.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11299263: Build chromedriver2_unittests as part of chromium_builder_tests. (Closed)

Created:
8 years ago by kkania

Modified:
8 years ago

Reviewers:
dennis_jeffrey

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Build chromedriver2_unittests as part of chromium_builder_tests. This is so it can be run optionally on the trybots. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=170508

Patch Set 2 : . #

Created: 8 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -1 line)			Patch
	M	build/all.gyp	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
	M	chrome/chrome_tests.gypi	View		1 chunk	+2 lines, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

dennis_jeffrey

LGTM with a nit. https://codereview.chromium.org/11299263/diff/1/build/all.gyp File build/all.gyp (right): https://codereview.chromium.org/11299263/diff/1/build/all.gyp#newcode197 build/all.gyp:197: '../chrome/chrome.gyp:chromedriver2_tests', swap with the line ...

8 years ago (2012-11-30 00:12:57 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kkania@chromium.org/11299263/5001

8 years ago (2012-11-30 17:30:44 UTC) #3

Message was sent while issue was closed.

Change committed as 170508

Expand Messages | Collapse Messages

Issue 11299263: Build chromedriver2_unittests as part of chromium_builder_tests. (Closed)

Description

Patch Set 1 #

Patch Set 2 : . #

Messages