Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Side by Side Diff: chrome/browser/policy/configuration_policy_handler_chromeos_unittest.cc

Issue 11299236: This moves the ONC parsing code into chromeos/network/onc (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: fix unit tests Created 8 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/policy/configuration_policy_handler_chromeos.h" 5 #include "chrome/browser/policy/configuration_policy_handler_chromeos.h"
6 6
7 #include "base/prefs/pref_value_map.h" 7 #include "base/prefs/pref_value_map.h"
8 #include "chrome/browser/policy/policy_error_map.h" 8 #include "chrome/browser/policy/policy_error_map.h"
9 #include "chrome/browser/policy/policy_map.h" 9 #include "chrome/browser/policy/policy_map.h"
10 #include "chrome/browser/ui/ash/chrome_launcher_prefs.h" 10 #include "chrome/browser/ui/ash/chrome_launcher_prefs.h"
11 #include "chrome/common/pref_names.h" 11 #include "chrome/common/pref_names.h"
12 #include "policy/policy_constants.h" 12 #include "policy/policy_constants.h"
13 #include "testing/gtest/include/gtest/gtest.h" 13 #include "testing/gtest/include/gtest/gtest.h"
14 14
15 namespace policy { 15 namespace policy {
16 16
17 TEST(NetworkConfigurationPolicyHandlerTest, Empty) { 17 TEST(NetworkConfigurationPolicyHandlerTest, Empty) {
18 PolicyMap policy_map; 18 PolicyMap policy_map;
19 NetworkConfigurationPolicyHandler handler( 19 NetworkConfigurationPolicyHandler handler(
20 key::kOpenNetworkConfiguration, 20 key::kOpenNetworkConfiguration,
21 chromeos::NetworkUIData::ONC_SOURCE_USER_POLICY); 21 chromeos::onc::ONC_SOURCE_USER_POLICY);
22 PolicyErrorMap errors; 22 PolicyErrorMap errors;
23 EXPECT_TRUE(handler.CheckPolicySettings(policy_map, &errors)); 23 EXPECT_TRUE(handler.CheckPolicySettings(policy_map, &errors));
24 EXPECT_TRUE(errors.GetErrors(key::kOpenNetworkConfiguration).empty()); 24 EXPECT_TRUE(errors.GetErrors(key::kOpenNetworkConfiguration).empty());
25 } 25 }
26 26
27 TEST(NetworkConfigurationPolicyHandlerTest, ValidONC) { 27 TEST(NetworkConfigurationPolicyHandlerTest, ValidONC) {
28 const std::string kTestONC( 28 const std::string kTestONC(
29 "{" 29 "{"
30 " \"NetworkConfigurations\": [{" 30 " \"NetworkConfigurations\": [{"
31 " \"GUID\": \"{485d6076-dd44-6b6d-69787465725f5045}\"," 31 " \"GUID\": \"{485d6076-dd44-6b6d-69787465725f5045}\","
32 " \"Type\": \"WiFi\"," 32 " \"Type\": \"WiFi\","
33 " \"Name\": \"some name\"," 33 " \"Name\": \"some name\","
34 " \"WiFi\": {" 34 " \"WiFi\": {"
35 " \"Security\": \"WEP-PSK\"," 35 " \"Security\": \"WEP-PSK\","
36 " \"SSID\": \"ssid\"," 36 " \"SSID\": \"ssid\","
37 " \"Passphrase\": \"pass\"," 37 " \"Passphrase\": \"pass\","
38 " }" 38 " }"
39 " }]" 39 " }]"
40 "}"); 40 "}");
41 41
42 PolicyMap policy_map; 42 PolicyMap policy_map;
43 policy_map.Set(key::kOpenNetworkConfiguration, 43 policy_map.Set(key::kOpenNetworkConfiguration,
44 POLICY_LEVEL_MANDATORY, 44 POLICY_LEVEL_MANDATORY,
45 POLICY_SCOPE_USER, 45 POLICY_SCOPE_USER,
46 Value::CreateStringValue(kTestONC)); 46 Value::CreateStringValue(kTestONC));
47 NetworkConfigurationPolicyHandler handler( 47 NetworkConfigurationPolicyHandler handler(
48 key::kOpenNetworkConfiguration, 48 key::kOpenNetworkConfiguration,
49 chromeos::NetworkUIData::ONC_SOURCE_USER_POLICY); 49 chromeos::onc::ONC_SOURCE_USER_POLICY);
50 PolicyErrorMap errors; 50 PolicyErrorMap errors;
51 EXPECT_TRUE(handler.CheckPolicySettings(policy_map, &errors)); 51 EXPECT_TRUE(handler.CheckPolicySettings(policy_map, &errors));
52 EXPECT_TRUE(errors.GetErrors(key::kOpenNetworkConfiguration).empty()); 52 EXPECT_TRUE(errors.GetErrors(key::kOpenNetworkConfiguration).empty());
53 } 53 }
54 54
55 TEST(NetworkConfigurationPolicyHandlerTest, WrongType) { 55 TEST(NetworkConfigurationPolicyHandlerTest, WrongType) {
56 PolicyMap policy_map; 56 PolicyMap policy_map;
57 policy_map.Set(key::kOpenNetworkConfiguration, 57 policy_map.Set(key::kOpenNetworkConfiguration,
58 POLICY_LEVEL_MANDATORY, 58 POLICY_LEVEL_MANDATORY,
59 POLICY_SCOPE_USER, 59 POLICY_SCOPE_USER,
60 Value::CreateBooleanValue(false)); 60 Value::CreateBooleanValue(false));
61 NetworkConfigurationPolicyHandler handler( 61 NetworkConfigurationPolicyHandler handler(
62 key::kOpenNetworkConfiguration, 62 key::kOpenNetworkConfiguration,
63 chromeos::NetworkUIData::ONC_SOURCE_USER_POLICY); 63 chromeos::onc::ONC_SOURCE_USER_POLICY);
64 PolicyErrorMap errors; 64 PolicyErrorMap errors;
65 EXPECT_FALSE(handler.CheckPolicySettings(policy_map, &errors)); 65 EXPECT_FALSE(handler.CheckPolicySettings(policy_map, &errors));
66 EXPECT_FALSE(errors.GetErrors(key::kOpenNetworkConfiguration).empty()); 66 EXPECT_FALSE(errors.GetErrors(key::kOpenNetworkConfiguration).empty());
67 } 67 }
68 68
69 TEST(NetworkConfigurationPolicyHandlerTest, JSONParseError) { 69 TEST(NetworkConfigurationPolicyHandlerTest, JSONParseError) {
70 const std::string kTestONC("I'm not proper JSON!"); 70 const std::string kTestONC("I'm not proper JSON!");
71 PolicyMap policy_map; 71 PolicyMap policy_map;
72 policy_map.Set(key::kOpenNetworkConfiguration, 72 policy_map.Set(key::kOpenNetworkConfiguration,
73 POLICY_LEVEL_MANDATORY, 73 POLICY_LEVEL_MANDATORY,
74 POLICY_SCOPE_USER, 74 POLICY_SCOPE_USER,
75 Value::CreateStringValue(kTestONC)); 75 Value::CreateStringValue(kTestONC));
76 NetworkConfigurationPolicyHandler handler( 76 NetworkConfigurationPolicyHandler handler(
77 key::kOpenNetworkConfiguration, 77 key::kOpenNetworkConfiguration,
78 chromeos::NetworkUIData::ONC_SOURCE_USER_POLICY); 78 chromeos::onc::ONC_SOURCE_USER_POLICY);
79 PolicyErrorMap errors; 79 PolicyErrorMap errors;
80 EXPECT_FALSE(handler.CheckPolicySettings(policy_map, &errors)); 80 EXPECT_FALSE(handler.CheckPolicySettings(policy_map, &errors));
81 EXPECT_FALSE(errors.GetErrors(key::kOpenNetworkConfiguration).empty()); 81 EXPECT_FALSE(errors.GetErrors(key::kOpenNetworkConfiguration).empty());
82 } 82 }
83 83
84 TEST(NetworkConfigurationPolicyHandlerTest, Sanitization) { 84 TEST(NetworkConfigurationPolicyHandlerTest, Sanitization) {
85 const std::string kTestONC( 85 const std::string kTestONC(
86 "{" 86 "{"
87 " \"NetworkConfigurations\": [{" 87 " \"NetworkConfigurations\": [{"
88 " \"GUID\": \"{485d6076-dd44-6b6d-69787465725f5045}\"," 88 " \"GUID\": \"{485d6076-dd44-6b6d-69787465725f5045}\","
89 " \"Type\": \"WiFi\"," 89 " \"Type\": \"WiFi\","
90 " \"Name\": \"some name\"," 90 " \"Name\": \"some name\","
91 " \"WiFi\": {" 91 " \"WiFi\": {"
92 " \"Security\": \"WEP-PSK\"," 92 " \"Security\": \"WEP-PSK\","
93 " \"SSID\": \"ssid\"," 93 " \"SSID\": \"ssid\","
94 " \"Passphrase\": \"pass\"," 94 " \"Passphrase\": \"pass\","
95 " }" 95 " }"
96 " }]" 96 " }]"
97 "}"); 97 "}");
98 98
99 PolicyMap policy_map; 99 PolicyMap policy_map;
100 policy_map.Set(key::kOpenNetworkConfiguration, 100 policy_map.Set(key::kOpenNetworkConfiguration,
101 POLICY_LEVEL_MANDATORY, 101 POLICY_LEVEL_MANDATORY,
102 POLICY_SCOPE_USER, 102 POLICY_SCOPE_USER,
103 Value::CreateStringValue(kTestONC)); 103 Value::CreateStringValue(kTestONC));
104 NetworkConfigurationPolicyHandler handler( 104 NetworkConfigurationPolicyHandler handler(
105 key::kOpenNetworkConfiguration, 105 key::kOpenNetworkConfiguration,
106 chromeos::NetworkUIData::ONC_SOURCE_USER_POLICY); 106 chromeos::onc::ONC_SOURCE_USER_POLICY);
107 PolicyErrorMap errors; 107 PolicyErrorMap errors;
108 handler.PrepareForDisplaying(&policy_map); 108 handler.PrepareForDisplaying(&policy_map);
109 const Value* sanitized = policy_map.GetValue(key::kOpenNetworkConfiguration); 109 const Value* sanitized = policy_map.GetValue(key::kOpenNetworkConfiguration);
110 ASSERT_TRUE(sanitized); 110 ASSERT_TRUE(sanitized);
111 std::string sanitized_onc; 111 std::string sanitized_onc;
112 EXPECT_TRUE(sanitized->GetAsString(&sanitized_onc)); 112 EXPECT_TRUE(sanitized->GetAsString(&sanitized_onc));
113 EXPECT_FALSE(sanitized_onc.empty()); 113 EXPECT_FALSE(sanitized_onc.empty());
114 EXPECT_EQ(std::string::npos, sanitized_onc.find("pass")); 114 EXPECT_EQ(std::string::npos, sanitized_onc.find("pass"));
115 } 115 }
116 116
(...skipping 18 matching lines...) Expand all
135 list.Append(entry1.DeepCopy()); 135 list.Append(entry1.DeepCopy());
136 policy_map.Set(key::kPinnedLauncherApps, POLICY_LEVEL_MANDATORY, 136 policy_map.Set(key::kPinnedLauncherApps, POLICY_LEVEL_MANDATORY,
137 POLICY_SCOPE_USER, list.DeepCopy()); 137 POLICY_SCOPE_USER, list.DeepCopy());
138 prefs.Clear(); 138 prefs.Clear();
139 handler.ApplyPolicySettings(policy_map, &prefs); 139 handler.ApplyPolicySettings(policy_map, &prefs);
140 EXPECT_TRUE(prefs.GetValue(prefs::kPinnedLauncherApps, &value)); 140 EXPECT_TRUE(prefs.GetValue(prefs::kPinnedLauncherApps, &value));
141 EXPECT_TRUE(base::Value::Equals(&expected_pinned_apps, value)); 141 EXPECT_TRUE(base::Value::Equals(&expected_pinned_apps, value));
142 } 142 }
143 143
144 } // namespace policy 144 } // namespace policy
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698