Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(538)

Issue 11299226: Pass FixedArrayBase in elements.cc. (Closed)

Created:
8 years ago by Toon Verwaest
Modified:
8 years ago
Reviewers:
danno
CC:
v8-dev
Visibility:
Public.

Description

Pass FixedArrayBase in elements.cc. This avoids casting problems in case of empty_fixed_array as FixedDoubleArray with size 0. This avoids prematurely shortcutting in case of 0 all over the place, which in turn leads to errors. Committed: https://code.google.com/p/v8/source/detail?r=13098

Patch Set 1 #

Patch Set 2 : Remove castOrEmptyFixedArray #

Unified diffs Side-by-side diffs Delta from patch set Stats (+149 lines, -147 lines) Patch
M src/elements.cc View 45 chunks +149 lines, -139 lines 0 comments Download
M src/objects.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M src/objects-inl.h View 1 1 chunk +0 lines, -7 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Toon Verwaest
PTAL
8 years ago (2012-11-28 09:56:41 UTC) #1
danno
8 years ago (2012-11-29 15:26:56 UTC) #2
lgtm

Powered by Google App Engine
This is Rietveld 408576698