Issue 11299226: Pass FixedArrayBase in elements.cc.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11299226: Pass FixedArrayBase in elements.cc. (Closed)

Created:
8 years ago by Toon Verwaest

Modified:
8 years ago

Reviewers:
danno

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Pass FixedArrayBase in elements.cc. This avoids casting problems in case of empty_fixed_array as FixedDoubleArray with size 0. This avoids prematurely shortcutting in case of 0 all over the place, which in turn leads to errors. Committed: https://code.google.com/p/v8/source/detail?r=13098

Patch Set 1 #

Patch Set 2 : Remove castOrEmptyFixedArray #

Created: 8 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+149 lines, -147 lines)			Patch
M	src/elements.cc	View		45 chunks	+149 lines, -139 lines	0 comments	Download
M	src/objects.h	View	1	1 chunk	+0 lines, -1 line	0 comments	Download
M	src/objects-inl.h	View	1	1 chunk	+0 lines, -7 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

lgtm

Expand Messages | Collapse Messages