Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(166)

Unified Diff: sdk/lib/_internal/compiler/implementation/ssa/codegen.dart

Issue 11299220: Add @JSName annotation for native fields and methods. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Fix _NodeList Created 8 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: sdk/lib/_internal/compiler/implementation/ssa/codegen.dart
diff --git a/sdk/lib/_internal/compiler/implementation/ssa/codegen.dart b/sdk/lib/_internal/compiler/implementation/ssa/codegen.dart
index 7e364c094b0b6bf319dfd1934609c1a740583e22..048874b62ac8c80d130b7286347daed64628b18a 100644
--- a/sdk/lib/_internal/compiler/implementation/ssa/codegen.dart
+++ b/sdk/lib/_internal/compiler/implementation/ssa/codegen.dart
@@ -1722,7 +1722,9 @@ abstract class SsaCodeGenerator implements HVisitor, HBlockInformationVisitor {
// property should not be mangled.
push(new js.PropertyAccess.field(pop(), 'length'), node);
} else {
- String name = backend.namer.getName(node.element);
+ String name = node.element.isNative()
ngeoffray 2012/11/28 20:31:23 Move this in the namer? It would avoid the code du
+ ? node.element.nativeName()
+ : backend.namer.getName(node.element);
push(new js.PropertyAccess.field(pop(), name), node);
HType receiverHType = types[node.receiver];
DartType type = receiverHType.computeType(compiler);
@@ -1734,7 +1736,9 @@ abstract class SsaCodeGenerator implements HVisitor, HBlockInformationVisitor {
}
visitFieldSet(HFieldSet node) {
- String name = backend.namer.getName(node.element);
+ String name = node.element.isNative()
+ ? node.element.nativeName()
+ : backend.namer.getName(node.element);
DartType type = types[node.receiver].computeType(compiler);
if (type != null) {
// Field setters in the generative constructor body are handled in a

Powered by Google App Engine
This is Rietveld 408576698