[Sync] Implement processing of history delete directives

[Sync] Implement processing of history delete directives

We still need to figure out how to keep track of already-processed
delete directives, but leave that as a TODO.

BUG=141245
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=170615

[akalin, 2012-11-27 23:22:44]

+brettw for review

Note that this depends on 11428036.

[brettw, 2012-11-29 21:29:56]

It might speed things up to have somebody else working on sync to review the
details of the time computations. I'm not familiar with the sync stuff and kind
of backed up anyway.

I'll LGTM the concept of adding this if somebody else checks your delete
directive manipulation details.

https://codereview.chromium.org/11299218/diff/1/chrome/browser/history/histor...
File chrome/browser/history/history.cc (right):

https://codereview.chromium.org/11299218/diff/1/chrome/browser/history/histor...
chrome/browser/history/history.cc:1137: namespace {
Please put all anon. namespace stuff at the top.

[akalin, 2012-11-29 21:31:52]

+zea for review of sync stuff

[Nicolas Zea, 2012-11-29 22:29:43]

LGTM

https://codereview.chromium.org/11299218/diff/8001/chrome/browser/history/his...
File chrome/browser/history/history.cc (right):

https://codereview.chromium.org/11299218/diff/8001/chrome/browser/history/his...
chrome/browser/history/history.cc:1153: VLOG(1) << "Processing delete directive:
"
dvlog? (here and below)

https://codereview.chromium.org/11299218/diff/8001/chrome/browser/history/his...
File chrome/browser/history/history_unittest.cc (right):

https://codereview.chromium.org/11299218/diff/8001/chrome/browser/history/his...
chrome/browser/history/history_unittest.cc:991: (base::Time::UnixEpoch() +
base::TimeDelta::FromMicroseconds(2))
add a 0 case as well?

[akalin, 2012-11-29 23:44:58]

All comments addressed.

Brett, was your previous comment a LGTM or should I wait?

https://codereview.chromium.org/11299218/diff/1/chrome/browser/history/histor...
File chrome/browser/history/history.cc (right):

https://codereview.chromium.org/11299218/diff/1/chrome/browser/history/histor...
chrome/browser/history/history.cc:1137: namespace {
On 2012/11/29 21:29:56, brettw wrote:
> Please put all anon. namespace stuff at the top.

Done.

https://codereview.chromium.org/11299218/diff/8001/chrome/browser/history/his...
File chrome/browser/history/history.cc (right):

https://codereview.chromium.org/11299218/diff/8001/chrome/browser/history/his...
chrome/browser/history/history.cc:1153: VLOG(1) << "Processing delete directive:
"
On 2012/11/29 22:29:43, Nicolas Zea wrote:
> dvlog? (here and below)

Done.  Also fixed existing cases above.

https://codereview.chromium.org/11299218/diff/8001/chrome/browser/history/his...
File chrome/browser/history/history_unittest.cc (right):

https://codereview.chromium.org/11299218/diff/8001/chrome/browser/history/his...
chrome/browser/history/history_unittest.cc:991: (base::Time::UnixEpoch() +
base::TimeDelta::FromMicroseconds(2))
On 2012/11/29 22:29:43, Nicolas Zea wrote:
> add a 0 case as well?

Done.

[brettw, 2012-11-29 23:50:47]

yeah, lgtm

[commit-bot: I haz the power, 2012-11-30 20:26:55]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/akalin@chromium.org/11299218/3007

[commit-bot: I haz the power, 2012-11-30 22:46:57]

Retried try job too often on linux_rel for step(s) content_unittests

[commit-bot: I haz the power, 2012-11-30 22:51:45]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/akalin@chromium.org/11299218/3007

[commit-bot: I haz the power, 2012-12-01 00:43:00]

Change committed as 170615