Issue 11299196: Handle the 'enter' key with the action 'ACTION_DOWN'

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11299196: Handle the 'enter' key with the action 'ACTION_DOWN' (Closed)

Created:
8 years ago by yongsheng

Modified:
8 years ago

Reviewers:
Ted C, bulach

CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, jochen+watch_chromium.org

Base URL:
http://git.chromium.org/git/chromium.git@trunk

Visibility:
Public.

More Reviews

Description

Handle the 'enter' key with the action 'ACTION_DOWN' Tests show that when pressing 'enter' key, content shell and test shell only receive the action 'ACTION_DOWN'. BUG= TEST= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=170398

Patch Set 1 #

Created: 8 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -3 lines)			Patch
	M	chrome/android/testshell/java/src/org/chromium/chrome/testshell/TestShellToolbar.java	View		2 chunks	+2 lines, -2 lines	0 comments	Download
	M	content/shell/android/java/src/org/chromium/content_shell/Shell.java	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

yongsheng

when pressing 'enter' key, android seems getting problems to send events to users: KeyEvent { ...

8 years ago (2012-11-27 08:40:05 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yongsheng.zhu@intel.com/11299196/1

8 years ago (2012-11-30 01:02:13 UTC) #4

Message was sent while issue was closed.

Change committed as 170398

Expand Messages | Collapse Messages