Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(596)

Unified Diff: ppapi/proxy/plugin_proxy_delegate.h

Issue 11299147: Pepper proxy: make the browser sender handle the proxy lock properly. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ppapi/proxy/plugin_proxy_delegate.h
diff --git a/ppapi/proxy/plugin_proxy_delegate.h b/ppapi/proxy/plugin_proxy_delegate.h
index de0c397eba80743ca26c079903fa54c94dac7d09..f2d7759918c4ac41233220388914fb62ad666836 100644
--- a/ppapi/proxy/plugin_proxy_delegate.h
+++ b/ppapi/proxy/plugin_proxy_delegate.h
@@ -18,12 +18,10 @@ class PPAPI_PROXY_EXPORT PluginProxyDelegate {
public:
virtual ~PluginProxyDelegate() {}
- // Sends the given message to the browser. Identical semantics to IPC::Sender
- // interface. New code should use GetBrowserSender instead.
- // TODO(brettw) remove this.
- virtual bool SendToBrowser(IPC::Message* msg) = 0;
-
// Returns the channel for sending to the browser.
+ // Note: The returned sender must be thread-safe. It might be used while the
+ // proxy lock is not acquired. Please see the implementation of
+ // PluginGlobals::BrowserSender.
virtual IPC::Sender* GetBrowserSender() = 0;
// Returns the language code of the current UI language.
@@ -31,6 +29,7 @@ class PPAPI_PROXY_EXPORT PluginProxyDelegate {
// Performs Windows-specific font caching in the browser for the given
// LOGFONTW. Does nothing on non-Windows platforms.
+ // Note: This method must be thread-safe.
virtual void PreCacheFont(const void* logfontw) = 0;
// Sets the active url which is reported by breakpad.

Powered by Google App Engine
This is Rietveld 408576698