Fix html select tag on 2nd display.

Fix html select tag on 2nd display.
- Translate the bounds_in_screen in InitAsPopup to parent
  coordinates.
- Don't remove observer if the browser window has been reparented.
  This can happen when a browser is moved to different display.
  I also moved Add/RemoveObserver to the WebContentsView's
  ctor/dtor to make it easy to follow which windows it is
  observing.

There is still one issue where this doesn't work IF the web content view's
parent isn't toplevel window. Only case I know of is constrained html dialog,
which doesn't have html select tag, so I'll leave it for now.
I'll address it when necessary.

BUG=161509
TEST=manual. see bug for repro step.


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=169204

[oshima, 2012-11-20 23:21:03]

https://codereview.chromium.org/11299119/diff/3001/content/browser/web_conten...
File content/browser/web_contents/web_contents_view_aura.cc (left):

https://codereview.chromium.org/11299119/diff/3001/content/browser/web_conten...
content/browser/web_contents/web_contents_view_aura.cc:281: // This is for the
Ash case.
This is necessary for non ash as well. WebContentView can move when you turn
on/off bookmark bar, or info bar.

[jam, 2012-11-21 19:21:02]

redirecting to sky, he knows this stuff much better than me

+1 to ignoring constrained windows for now. none of the constrained windows
move, so this issue shouldn't exist ther.e

[oshima, 2012-11-21 19:29:55]

On 2012/11/21 19:21:02, John Abd-El-Malek wrote:
> redirecting to sky, he knows this stuff much better than me
> 
> +1 to ignoring constrained windows for now. none of the constrained windows
> move, so this issue shouldn't exist ther.e

The browser window that contains a constrained window can move, and
when it does, we need to update rects. It's used only for certificate viewer
right now, which doesn't have html select tag, so this shouldn't cause real
issue now.

[sky, 2012-11-21 22:42:20]

LGTM

[commit-bot: I haz the power, 2012-11-22 00:24:08]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/oshima@chromium.org/11299119/3001

[commit-bot: I haz the power, 2012-11-22 00:24:31]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/oshima@chromium.org/11299119/3001

[commit-bot: I haz the power, 2012-11-22 01:12:15]

Step "update" is always a major failure.
Look at the try server FAQ for more details.

[commit-bot: I haz the power, 2012-11-22 01:13:49]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/oshima@chromium.org/11299119/3001

[commit-bot: I haz the power, 2012-11-22 03:19:45]

Change committed as 169204