Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(94)

Issue 11299083: Fixes for nonmodal pinch zoom. (Closed)

Created:
8 years, 1 month ago by aelias_OOO_until_Jul13
Modified:
8 years, 1 month ago
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, cc-bugs_chromium.org, jam, klobag.chromium, Yusuf, wjmaclean, sadrul
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Fixes for nonmodal pinch zoom. In Android 4.2, pinch gestures send both pinch events (for the zoom-in/out part of the pinch) and scroll events (for double-finger panning). The previous logic in LayerTreeHostImpl created a pan from the pinch event, resulting in 2x overpanning on Android 4.2. In order to have compatible gesture generation in older Android versions as well, I copy-pasted the latest Android GestureDetector.java file into the Chromium tree and use that instead of the system file. BUG=161909 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=168721

Patch Set 1 #

Patch Set 2 : Remove debug logging #

Patch Set 3 : Fix ContentViewGestureHandlerTest #

Patch Set 4 : Whitelist findbugs and fix cc_unittests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+731 lines, -10 lines) Patch
M build/android/findbugs_filter/findbugs_known_bugs.txt View 1 2 3 1 chunk +2 lines, -0 lines 0 comments Download
M cc/layer_tree_host_impl.cc View 1 1 chunk +1 line, -4 lines 0 comments Download
M cc/layer_tree_host_impl_unittest.cc View 1 2 3 2 chunks +22 lines, -1 line 0 comments Download
M content/public/android/java/src/org/chromium/content/browser/ContentViewGestureHandler.java View 2 chunks +3 lines, -4 lines 0 comments Download
A content/public/android/java/src/org/chromium/content/browser/third_party/GestureDetector.java View 1 chunk +701 lines, -0 lines 0 comments Download
M content/public/android/javatests/src/org/chromium/content/browser/ContentViewGestureHandlerTest.java View 1 2 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 15 (0 generated)
aelias_OOO_until_Jul13
Hi Robert. This will break ChromeOS until you update your gesture detector to behave similarly. ...
8 years, 1 month ago (2012-11-19 21:44:27 UTC) #1
klobag.chromium
lgtm
8 years, 1 month ago (2012-11-19 22:14:22 UTC) #2
danakj
Do we have a ChromeOS fix underway?
8 years, 1 month ago (2012-11-19 22:19:30 UTC) #3
rjkroege
On 2012/11/19 22:19:30, danakj wrote: > Do we have a ChromeOS fix underway? AFAIK: this ...
8 years, 1 month ago (2012-11-19 22:32:06 UTC) #4
danakj
ok, cc/ LGTM
8 years, 1 month ago (2012-11-19 22:46:20 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/aelias@chromium.org/11299083/2001
8 years, 1 month ago (2012-11-19 23:20:24 UTC) #6
commit-bot: I haz the power
Presubmit check for 11299083-2001 failed and returned exit status 1. Running presubmit commit checks ...
8 years, 1 month ago (2012-11-19 23:20:30 UTC) #7
aelias_OOO_until_Jul13
tedchoc@, could you give OWNERS approval?
8 years, 1 month ago (2012-11-19 23:35:10 UTC) #8
Ted C
lgtm
8 years, 1 month ago (2012-11-19 23:38:39 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/aelias@chromium.org/11299083/2001
8 years, 1 month ago (2012-11-19 23:42:10 UTC) #10
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
8 years, 1 month ago (2012-11-20 00:14:15 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/aelias@chromium.org/11299083/7003
8 years, 1 month ago (2012-11-20 00:27:57 UTC) #12
commit-bot: I haz the power
Retried try job too often for step(s) build
8 years, 1 month ago (2012-11-20 00:59:46 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/aelias@chromium.org/11299083/10003
8 years, 1 month ago (2012-11-20 01:15:35 UTC) #14
commit-bot: I haz the power
8 years, 1 month ago (2012-11-20 04:11:59 UTC) #15
Change committed as 168721

Powered by Google App Engine
This is Rietveld 408576698