Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(407)

Issue 11299074: Make use_aura set use_default_render_theme and moves (Closed)

Created:
8 years, 1 month ago by sky
Modified:
8 years ago
Reviewers:
tony, jam
CC:
chromium-reviews, darin-cc_chromium.org
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Make use_aura set use_default_render_theme and moves webthemeengine_impl_linux to webthemeengine_impl_default. BUG=none TEST=none R=tony@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=169958

Patch Set 1 #

Patch Set 2 : Merge 2 trunk and update some ifdefs #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -226 lines) Patch
M build/common.gypi View 1 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/renderer_preferences_util.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/render_view_impl.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M webkit/glue/webkit_glue.gypi View 1 2 chunks +13 lines, -2 lines 0 comments Download
M webkit/glue/webkitplatformsupport_impl.h View 1 chunk +3 lines, -4 lines 0 comments Download
A + webkit/glue/webthemeengine_impl_default.h View 2 chunks +4 lines, -4 lines 0 comments Download
A + webkit/glue/webthemeengine_impl_default.cc View 1 chunk +1 line, -1 line 0 comments Download
D webkit/glue/webthemeengine_impl_linux.h View 1 chunk +0 lines, -26 lines 0 comments Download
D webkit/glue/webthemeengine_impl_linux.cc View 1 chunk +0 lines, -185 lines 0 comments Download

Messages

Total messages: 13 (0 generated)
sky
8 years, 1 month ago (2012-11-19 16:17:02 UTC) #1
tony
LGTM
8 years, 1 month ago (2012-11-19 16:41:06 UTC) #2
sky
After landing the last set of webkit changes this is ready for another look.
8 years ago (2012-11-27 01:38:23 UTC) #3
tony
LGTM
8 years ago (2012-11-27 17:37:42 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sky@chromium.org/11299074/1010
8 years ago (2012-11-27 17:59:51 UTC) #5
commit-bot: I haz the power
Presubmit check for 11299074-1010 failed and returned exit status 1. Running presubmit commit checks ...
8 years ago (2012-11-27 18:00:00 UTC) #6
sky
John, could you look at the change to content/renderer/render_view_impl.cc .
8 years ago (2012-11-27 18:51:40 UTC) #7
jam
lgtm
8 years ago (2012-11-27 23:26:03 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sky@chromium.org/11299074/1010
8 years ago (2012-11-27 23:35:44 UTC) #9
commit-bot: I haz the power
Step "update" is always a major failure. Look at the try server FAQ for more ...
8 years ago (2012-11-28 00:49:37 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sky@chromium.org/11299074/1010
8 years ago (2012-11-28 00:54:32 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sky@chromium.org/11299074/1010
8 years ago (2012-11-28 15:03:23 UTC) #12
commit-bot: I haz the power
8 years ago (2012-11-28 15:52:28 UTC) #13
Message was sent while issue was closed.
Change committed as 169958

Powered by Google App Engine
This is Rietveld 408576698