Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(654)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 11299057: Add android chromium.perf top level scripts (Closed)

Created:
8 years, 1 month ago by Isaac (away)
Modified:
8 years, 1 month ago
Reviewers:
cmp
CC:
chromium-reviews, ilevy+watch_chromium.org, bulach+watch_chromium.org, yfriedman+watch_chromium.org, peter+watch_chromium.org, klundberg+watch_chromium.org, frankf+watch_chromium.org
Visibility:
Public.

Description

Add android chromium.perf top level scripts BUG=159643 R=cmp NOTRY=true Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=168362

Patch Set 1 #

Total comments: 2

Patch Set 2 : remove findbugs from builder #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -6 lines) Patch
A + build/android/buildbot/bb_perf_builder.sh View 1 2 chunks +2 lines, -1 line 0 comments Download
A + build/android/buildbot/bb_perf_gn_tests.sh View 2 chunks +2 lines, -5 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Isaac (away)
8 years, 1 month ago (2012-11-17 03:06:11 UTC) #1
cmp
lgtm with change https://codereview.chromium.org/11299057/diff/1/build/android/buildbot/bb_perf_builder.sh File build/android/buildbot/bb_perf_builder.sh (right): https://codereview.chromium.org/11299057/diff/1/build/android/buildbot/bb_perf_builder.sh#newcode14 build/android/buildbot/bb_perf_builder.sh:14: bb_run_findbugs Sounds like you're planning to ...
8 years, 1 month ago (2012-11-17 03:07:35 UTC) #2
Isaac (away)
removed findbugs, committing. https://codereview.chromium.org/11299057/diff/1/build/android/buildbot/bb_perf_builder.sh File build/android/buildbot/bb_perf_builder.sh (right): https://codereview.chromium.org/11299057/diff/1/build/android/buildbot/bb_perf_builder.sh#newcode14 build/android/buildbot/bb_perf_builder.sh:14: bb_run_findbugs On 2012/11/17 03:07:35, cmp wrote: ...
8 years, 1 month ago (2012-11-17 03:08:33 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ilevy@chromium.org/11299057/3001
8 years, 1 month ago (2012-11-17 03:09:30 UTC) #4
commit-bot: I haz the power
8 years, 1 month ago (2012-11-17 03:11:23 UTC) #5 
Change committed as 168362

Powered by Google App Engine
This is Rietveld 408576698