Issue 11299044: Unittest to go along with added no suggest flag. Currently tests no suggest for English dictionarie…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11299044: Unittest to go along with added no suggest flag. Currently tests no suggest for English dictionarie… (Closed)

Created:
8 years, 1 month ago by rpetterson

Modified:
8 years, 1 month ago

Reviewers:
groby-ooo-7-16, sky

CC:
chromium-reviews, groby+spellwatch_chromium.org, rpetterson, darin-cc_chromium.org

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Unittest to go along with added no suggest flag. Currently tests no suggest for English dictionaries. Also updates DEPS to the new dictionary including the NOSUGGEST feature. BUG=160847 TBR=sky@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=168390

Created: 8 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+64 lines, -3 lines)			Patch
M	DEPS	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/common/spellcheck_common.cc	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	chrome/renderer/spellchecker/spellcheck_unittest.cc	View	1	1 chunk	+61 lines, -0 lines	0 comments	Download

Total messages: 7 (0 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rlp@chromium.org/11299044/4001

8 years, 1 month ago (2012-11-16 21:47:10 UTC) #3

commit-bot: I haz the power

Presubmit check for 11299044-4001 failed and returned exit status 1. Running presubmit commit checks ...

8 years, 1 month ago (2012-11-16 21:47:13 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rlp@chromium.org/11299044/4001

8 years, 1 month ago (2012-11-16 21:49:47 UTC) #6

Change committed as 168390