Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(85)

Issue 11299044: Unittest to go along with added no suggest flag. Currently tests no suggest for English dictionarie… (Closed)

Created:
8 years, 1 month ago by rpetterson
Modified:
8 years, 1 month ago
Reviewers:
groby-ooo-7-16, sky
CC:
chromium-reviews, groby+spellwatch_chromium.org, rpetterson, darin-cc_chromium.org
Visibility:
Public.

Description

Unittest to go along with added no suggest flag. Currently tests no suggest for English dictionaries. Also updates DEPS to the new dictionary including the NOSUGGEST feature. BUG=160847 TBR=sky@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=168390

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+64 lines, -3 lines) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/spellcheck_common.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/renderer/spellchecker/spellcheck_unittest.cc View 1 1 chunk +61 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
rpetterson
8 years, 1 month ago (2012-11-16 19:38:55 UTC) #1
groby-ooo-7-16
lgtm
8 years, 1 month ago (2012-11-16 21:46:29 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rlp@chromium.org/11299044/4001
8 years, 1 month ago (2012-11-16 21:47:10 UTC) #3
commit-bot: I haz the power
Presubmit check for 11299044-4001 failed and returned exit status 1. Running presubmit commit checks ...
8 years, 1 month ago (2012-11-16 21:47:13 UTC) #4
rpetterson
sky added as TBR reviewer for chrome
8 years, 1 month ago (2012-11-16 21:49:13 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rlp@chromium.org/11299044/4001
8 years, 1 month ago (2012-11-16 21:49:47 UTC) #6
commit-bot: I haz the power
8 years, 1 month ago (2012-11-17 06:36:10 UTC) #7
Change committed as 168390

Powered by Google App Engine
This is Rietveld 408576698