Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Issue 11299024: Revert 168080 - Configure system-level Chrome settings (i.e. install its shortcuts) immediately fol… (Closed)

Created:
8 years, 1 month ago by garykac
Modified:
8 years, 1 month ago
Reviewers:
gab
CC:
chromium-reviews, grt+watch_chromium.org
Visibility:
Public.

Description

Revert 168080 - Configure system-level Chrome settings (i.e. install its shortcuts) immediately following self-destruction of a user-level Chrome. Also refactor RemoveShortcut() to use base::win::ResolveShortcut() instead of coming up with its own method (which I'm scared could still hold handles to the shortcut when trying to delete it; doesn't seem to have been a problem, but I'd rather be safe). BUG=158524 TEST=Install user-level Chrome on user A, install system-level Chrome on user B (while A is still logged in), go back to user A and run Chrome, user-level Chrome self-destructs and new shortcuts are installed pointing to system-level Chrome. Review URL: https://chromiumcodereview.appspot.com/11359219 TBR=gab@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=168099

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -18 lines) Patch
M chrome/installer/setup/uninstall.cc View 1 chunk +0 lines, -12 lines 0 comments Download
M chrome/installer/util/shell_util.cc View 1 chunk +14 lines, -6 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
garykac
8 years, 1 month ago (2012-11-16 01:08:49 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698