Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(430)

Unified Diff: test/mjsunit/array-length.js

Issue 11299004: Use the property load IC for accessing the array length. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 8 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« src/objects.h ('K') | « src/objects-inl.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/mjsunit/array-length.js
diff --git a/test/mjsunit/array-length.js b/test/mjsunit/array-length.js
index 16867db733b6c98bb45b9428b86755d6c1e58e5d..98be7e7ac27c860148f70c403fdfbb801628c5ca 100644
--- a/test/mjsunit/array-length.js
+++ b/test/mjsunit/array-length.js
@@ -25,6 +25,8 @@
// (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
// OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
+// Flags: --allow-natives-syntax
+
var a = [0,1,2,3];
assertEquals(0, a.length = 0);
@@ -119,3 +121,32 @@ for (var i = 0; i < 7; i++) {
t = a.length = 7;
assertEquals(7, t);
}
+
+function TestLengthAccess() {
+ var TestGetLength = function(a, l, getLength, getKeyedLength) {
+ assertEquals(l, getLength(a));
+ assertEquals(l, getKeyedLength(a));
+ }
+
+ var Test = function(a, l) {
+ var getLength = function(a) { return a.length; }
Jakob Kummerow 2012/11/16 12:57:10 What's the point of doing this? Are you trying to
Massi 2012/11/19 12:26:15 Yes, now I am creating new functions every time.
+ var getKeyedLength = function(a) { return a['length']; }
+ // Make the ICs reach the state we want.
+ TestGetLength(a, l, getLength, getKeyedLength);
+ TestGetLength(a, l, getLength, getKeyedLength);
+ TestGetLength(a, l, getLength, getKeyedLength);
+ // Also test crankshaft.
+ %OptimizeFunctionOnNextCall(getLength);
+ %OptimizeFunctionOnNextCall(getKeyedLength);
+ TestGetLength(a, l, getLength, getKeyedLength);
+ }
+
+ Test(new Array(4), 4);
+ Test([1, 2, 3, 4], 4);
+ Test(Object.create(new Array(4)), 4);
+ length = 4;
Jakob Kummerow 2012/11/16 12:57:10 unused variable?
Massi 2012/11/19 12:26:15 No, I am setting the 'length property' of the glob
+ var globalObject = (1,eval)("this");
+ Test(globalObject, 4);
+}
+TestLengthAccess();
+
« src/objects.h ('K') | « src/objects-inl.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698