Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(327)

Side by Side Diff: test/mjsunit/array-length.js

Issue 11299004: Use the property load IC for accessing the array length. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 8 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« src/objects.h ('K') | « src/objects-inl.h ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2008 the V8 project authors. All rights reserved. 1 // Copyright 2008 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
11 // with the distribution. 11 // with the distribution.
12 // * Neither the name of Google Inc. nor the names of its 12 // * Neither the name of Google Inc. nor the names of its
13 // contributors may be used to endorse or promote products derived 13 // contributors may be used to endorse or promote products derived
14 // from this software without specific prior written permission. 14 // from this software without specific prior written permission.
15 // 15 //
16 // THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS 16 // THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
17 // "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT 17 // "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
18 // LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR 18 // LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
19 // A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT 19 // A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
20 // OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, 20 // OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
21 // SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT 21 // SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
22 // LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, 22 // LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
23 // DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY 23 // DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
24 // THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT 24 // THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
25 // (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE 25 // (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
26 // OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. 26 // OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
27 27
28 // Flags: --allow-natives-syntax
29
28 var a = [0,1,2,3]; 30 var a = [0,1,2,3];
29 assertEquals(0, a.length = 0); 31 assertEquals(0, a.length = 0);
30 32
31 assertEquals('undefined', typeof a[0]); 33 assertEquals('undefined', typeof a[0]);
32 assertEquals('undefined', typeof a[1]); 34 assertEquals('undefined', typeof a[1]);
33 assertEquals('undefined', typeof a[2]); 35 assertEquals('undefined', typeof a[2]);
34 assertEquals('undefined', typeof a[3]); 36 assertEquals('undefined', typeof a[3]);
35 37
36 38
37 var a = [0,1,2,3]; 39 var a = [0,1,2,3];
(...skipping 74 matching lines...) Expand 10 before | Expand all | Expand 10 after
112 114
113 // Check case of compiled stubs. 115 // Check case of compiled stubs.
114 var a = []; 116 var a = [];
115 for (var i = 0; i < 7; i++) { 117 for (var i = 0; i < 7; i++) {
116 assertEquals(3, a.length = 3); 118 assertEquals(3, a.length = 3);
117 119
118 var t = 239; 120 var t = 239;
119 t = a.length = 7; 121 t = a.length = 7;
120 assertEquals(7, t); 122 assertEquals(7, t);
121 } 123 }
124
125 function TestLengthAccess() {
126 var TestGetLength = function(a, l, getLength, getKeyedLength) {
127 assertEquals(l, getLength(a));
128 assertEquals(l, getKeyedLength(a));
129 }
130
131 var Test = function(a, l) {
132 var getLength = function(a) { return a.length; }
Jakob Kummerow 2012/11/16 12:57:10 What's the point of doing this? Are you trying to
Massi 2012/11/19 12:26:15 Yes, now I am creating new functions every time.
133 var getKeyedLength = function(a) { return a['length']; }
134 // Make the ICs reach the state we want.
135 TestGetLength(a, l, getLength, getKeyedLength);
136 TestGetLength(a, l, getLength, getKeyedLength);
137 TestGetLength(a, l, getLength, getKeyedLength);
138 // Also test crankshaft.
139 %OptimizeFunctionOnNextCall(getLength);
140 %OptimizeFunctionOnNextCall(getKeyedLength);
141 TestGetLength(a, l, getLength, getKeyedLength);
142 }
143
144 Test(new Array(4), 4);
145 Test([1, 2, 3, 4], 4);
146 Test(Object.create(new Array(4)), 4);
147 length = 4;
Jakob Kummerow 2012/11/16 12:57:10 unused variable?
Massi 2012/11/19 12:26:15 No, I am setting the 'length property' of the glob
148 var globalObject = (1,eval)("this");
149 Test(globalObject, 4);
150 }
151 TestLengthAccess();
152
OLDNEW
« src/objects.h ('K') | « src/objects-inl.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698