chrome/browser/media_gallery/media_file_system_registry_unittest.cc - Issue 11297002: [Media Gallery] Added code to support mtp device media file system on Windows.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/media_gallery/media_file_system_registry_unittest.cc

Issue 11297002: [Media Gallery] Added code to support mtp device media file system on Windows. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Addressed review comment and disabled MediaFileSystemRegistryTest.GalleryNameMTP Created 7 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/media_gallery/media_file_system_registry.cc ('k') | chrome/browser/media_gallery/win/mtp_device_delegate_impl_win.h » ('j') | chrome/browser/media_gallery/win/mtp_device_delegate_impl_win.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/media_gallery/media_file_system_registry_unittest.cc

diff --git a/chrome/browser/media_gallery/media_file_system_registry_unittest.cc b/chrome/browser/media_gallery/media_file_system_registry_unittest.cc

index 72c2f496eb571bab8f5ddaf8e81dfbd3e6971ebe..b71c934860ccfac0c521cc97c0e7154ad1ec73c7 100644

--- a/chrome/browser/media_gallery/media_file_system_registry_unittest.cc

+++ b/chrome/browser/media_gallery/media_file_system_registry_unittest.cc

@@ -786,7 +786,13 @@ TEST_F(MediaFileSystemRegistryTest, GalleryNameDefault) {

}

-#if defined(SUPPORT_MTP_DEVICE_FILESYSTEM)

+#if defined(SUPPORT_MTP_DEVICE_FILESYSTEM) && !defined(OS_WIN)

kmadhusu 2013/01/11 19:01:59 On Windows, this test depends on RemovableDeviceN

+// TODO(kmadhusu) : On Windows, this test depends on

+// RemovableDeviceNotificationsWindowWin to get the attached MTP device

+// storage details. Enable this test after refactoring

+// removable_device_notifications_window_win_unittest.cc to share the

+// mock classes (TestRemovableDeviceNotificationsWindowWin,

+// TestPortableDeviceWatcherWin and TestVolumeMountWatcherWin).

TEST_F(MediaFileSystemRegistryTest, GalleryNameMTP) {

std::set<std::string> gallery_names;

InitForGalleryNamesTest(&gallery_names);