cc: Make --jank-instead-of-checkerboard jank more often

cc: Make --jank-instead-of-checkerboard jank more often

Prior to this patch, "force drawn" frames would also get drawn.  As frames
get forced after commit if three frames in a row fail to draw, this happens
fairly often.

BUG=none


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=163928

[danakj, 2012-10-24 20:23:39]

https://codereview.chromium.org/11294003/diff/1/cc/thread_proxy.cc
File cc/thread_proxy.cc (right):

https://codereview.chromium.org/11294003/diff/1/cc/thread_proxy.cc#newcode712
cc/thread_proxy.cc:712: if (forcedDraw &&
!Settings::jankInsteadOfCheckerboard())
Is this going to break readbacks or whatever else uses forced draws?

Shouldn't we just prevent the forcedDraw from being scheduled?

[enne (OOO), 2012-10-24 20:27:35]

Ah, quite right.

https://codereview.chromium.org/11294003/diff/1/cc/thread_proxy.cc
File cc/thread_proxy.cc (right):

https://codereview.chromium.org/11294003/diff/1/cc/thread_proxy.cc#newcode712
cc/thread_proxy.cc:712: if (forcedDraw &&
!Settings::jankInsteadOfCheckerboard())
On 2012/10/24 20:23:39, danakj wrote:
> Is this going to break readbacks or whatever else uses forced draws?
> 
> Shouldn't we just prevent the forcedDraw from being scheduled?

Done.

[danakj, 2012-10-24 20:28:09]

nice, thanks. lgtm

[danakj, 2012-10-24 20:29:30]

aside: too bad we can't differential scroll checkerboards vs animation
checkerboards. with this flag animations would jank too.

[commit-bot: I haz the power, 2012-10-24 20:29:55]

No LGTM from a valid reviewer yet. Only full committers are accepted.
Even if an LGTM may have been provided, it was from a non-committer or
a lowly provisional committer, _not_ a full super star committer.
See http://www.chromium.org/getting-involved/become-a-committer
Note that this has nothing to do with OWNERS files.

[danakj, 2012-10-24 20:30:04]

differentiate*

[jamesr, 2012-10-24 20:43:58]

lgtm
On Oct 24, 2012 1:29 PM, <commit-bot@chromium.org> wrote:

> No LGTM from a valid reviewer yet. Only full committers are accepted.
> Even if an LGTM may have been provided, it was from a non-committer or
> a lowly provisional committer, _not_ a full super star committer.
> See
http://www.chromium.org/**getting-involved/become-a-**committer<http://www.ch...
> Note that this has nothing to do with OWNERS files.
>
>
https://chromiumcodereview.**appspot.com/11294003/<https://chromiumcodereview...
>
> --
>
>
>

[commit-bot: I haz the power, 2012-10-24 20:44:52]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/enne@chromium.org/11294003/5001

[commit-bot: I haz the power, 2012-10-24 22:25:59]

Change committed as 163928