build/gyp_helper.py - Issue 11293286: Use universal newlines in gyp_helper.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: build/gyp_helper.py

Issue 11293286: Use universal newlines in gyp_helper. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master

Patch Set: Created 8 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: build/gyp_helper.py

diff --git a/build/gyp_helper.py b/build/gyp_helper.py

index 69a341de4f61b852e193427410907579e90248d1..63debcdd850dcc800095f307698fb958b718fa28 100644

--- a/build/gyp_helper.py

+++ b/build/gyp_helper.py

@@ -15,7 +15,7 @@ def apply_gyp_environment_from_file(file_path):

"""Reads in a *.gyp_env file and applies the valid keys to os.environ."""

if not os.path.exists(file_path):

return

- with open(file_path) as f:

+ with open(file_path, 'rU') as f:

file_contents = f.read()

try:

file_data = eval(file_contents, {'__builtins__': None}, None)

« no previous file with comments | « no previous file | no next file » | no next file with comments »