Issue 11293286: Use universal newlines in gyp_helper.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11293286: Use universal newlines in gyp_helper. (Closed)

Created:
8 years, 1 month ago by iannucci

Modified:
8 years, 1 month ago

Reviewers:
Mike Stip (use stip instead)

CC:
chromium-reviews, huangs

Base URL:
http://git.chromium.org/chromium/src.git@master

Visibility:
Public.

Use universal newlines in gyp_helper. This avoids a stack trace for developers who have dos line endings in their chromium.gyp_env files. BUG= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=167817

Created: 8 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	build/gyp_helper.py	View		1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 4 (0 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/iannucci@chromium.org/11293286/1

8 years, 1 month ago (2012-11-14 23:04:48 UTC) #3

Change committed as 167817