Initial version of a serialization framework

pkg/serialization/lib/serialization.dart

Index: pkg/serialization/lib/serialization.dart
===================================================================
--- pkg/serialization/lib/serialization.dart	(revision 0)
+++ pkg/serialization/lib/serialization.dart	(revision 0)
@@ -0,0 +1,397 @@
+// Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
+// for details. All rights reserved. Use of this source code is governed by a
+// BSD-style license that can be found in the LICENSE file.
+
+/**
+ * This provides a general-purpose serialization facility for Dart objects. A
+ * [Serialization] is defined in terms of [SerializationRule]s and supports
+ * reading and writing to different formats.
+ *
+ * Setup
+ * =====
+ * A simple example of usage is
+ *
+ *      var address = new Address();
+ *      address.street = 'N 34th';
+ *      address.city = 'Seattle';
+ *      var serialization = new Serialization()
+ *          ..addRuleFor(address);

[justinfagnani, 2012/11/20 02:05:30]

I'm confused by this line here: does it att a rule for the instance address, or
the class Address? If it's the class, consider using Type as the parameter type
and address.runtimeType in the example code for now.

[Alan Knight, 2012/11/20 15:03:54]

This is all just workaround for being able to use the type name. But right now
the only way I know of to get a ClassMirror is via an instance. Even using
anInstance.runtimeType doesn't work, because a mirror on the type is an
instanceMirror of an instance of Type.

+ *      String output = serialization.write(address);
+ *
+ * This creates a new serialization and adds a rule for address objects. Right

[justinfagnani, 2012/11/20 02:05:30]

Why is it called "serialization" and not "serializer". I would expect that a
serialization is the result of serializing some object.

[Alan Knight, 2012/11/20 15:03:54]

Because it's better to name objects for what they represent than what they do?
Also, I'd think a serializer is an object that serializes, which this doesn't do
- that's Writer (which I wish I had a non "er" name for). Rather than being the
thing that serializes, this is the definition of a serialization scheme. So
grammatically it makes sense to me as serialization. You define a serialization.
In some cases you have different objects on the client side and on the server,
so you need to use different serializations in each place.  And so on.

+ * now it has to be passed an address instance because we can't write Address
+ * as a literal. Then we ask the Serialization to write the address and we get
+ * back a String which is a [JSON] representation of the state of it and related
+ * objects.
+ *
+ * The version above used reflection to automatically identify the public
+ * fields of the address object. We can also specify those fields explicitly.
+ *
+ *      var serialization = new Serialization()
+ *        ..addRuleFor(address,

[justinfagnani, 2012/11/20 02:05:30]

"Rule" as a name here doesn't seem ideal to me. Every other time I've
encountered this concept it's usually been named "custom serializer" or
something similar.

[Alan Knight, 2012/11/20 15:03:54]

Hmm. Rule is a lot shorter than custom serializer. These are also, or at least
can be, depending on the implementation, reasonably declarative, which I thought
fit more with the idea of a rule. Saying that a serialization is defined by a
series of rules seems to make sense.

+ *            constructor: "create",
+ *            constructorFields: ["number", "street"],
+ *            fields: ["city"]);
+ *
+ * This rule still uses reflection to access the fields, but not to calculate

[justinfagnani, 2012/11/20 02:05:30]

Is there a way to clarify the phrase "not to calculate them"? maybe "not
determine which fields to serialize"

[Alan Knight, 2012/11/20 15:03:54]

Done.

+ * them. We can also allow it to calculate the fields, but tell it to ignore
+ * some fields that we don't want used.
+ *
+ *      var serialization = new Serialization()
+ *        ..addRuleFor(address,
+ *            constructor: "",
+ *            excludeFields: ["other", "stuff"]);
+ *
+ * We can also use a completely non-reflective rule to serialize and
+ * de-serialize objects.
+ *
+ *      addressToMap(a) => {"number" : a.number, "street" : a.street,
+ *          "city" : a.city};
+ *      createAddress(Map m) => new Address.create(m["number"], m["street"]);
+ *      fillInAddress(Map m, Address a) => a.city = m["city"];
+ *      var serialization = new Serialization()
+ *        ..addRule(
+ *            new ClosureToMapRule(anAddress.runtimeType,

[justinfagnani, 2012/11/20 02:05:30]

When using many closures together I find it cleaner to just define a class
rather than to pass them all to a constructor. As a writer of rules, I'd rather
write:

class AddressRule extends Rule<Address> {
  final Type type = anAddress.type; // fix when literals are supported
  Map toMap(a) => {"number" : a.number, "street" : a.street, "city" : a.city};
  Address fromMap(Map m) => new Address.create(m["number"], m["street"]);
  void fillIn(Address a, Map m) => a.city = m["city"];
}

var serialization = new Serialization()..addRule(new AddressRule());

[Alan Knight, 2012/11/20 15:03:54]

Yes. And the intent is that people can do that, which you'd do just by
subclassing SerializationRule. So there's not much for the framework to do. But
that should have an example, and some documentation, and possibly an abstract
superclass designed to be subclassed for that purpose. Added a TODO (in
serialization_rule.dart).

+ *                addressToMap, createAddress, fillInAddress);
+ *
+ * Note that there are three different functions provided. The first one

[justinfagnani, 2012/11/20 02:05:30]

"first one" -> "addressToMap"

[Alan Knight, 2012/11/20 15:03:54]

Done.

+ * takes the fields we want serialized from the Address and puts them into a
+ * map. The second one creates a new address using a map like the one returned

[justinfagnani, 2012/11/20 02:05:30]

"second one" -> "createAddress"

[Alan Knight, 2012/11/20 15:03:54]

Done.

+ * by the first function. And the third one fills in any remaining state in the
+ * created object. At the moment, however, this is more likely to cause problems

[justinfagnani, 2012/11/20 02:05:30]

Consider breaking this paragraph up, maybe right before "At the moment,"

[Alan Knight, 2012/11/20 15:03:54]

Done.

+ * with cycles. The problem is that before passing values to the user-supplied
+ * functions it has to inflate any references to be the real objects. Since it
+ * doesn't know which ones the creation function uses it has to inflate all of
+ * them. For example, consider a Node class with parent, leftChild, and
+ * rightChild, and the parent field was final and set in the constructor. When
+ * we inflate all of the values we will end up with a cycle and can't
+ * de-serialize. If we know which fields are used by the constructor we can
+ * inflate only those, which is what BasicRule does. We expect to make a richer
+ * API for rules not using reflection, but there's a tension between providing
+ * the serialization process with enough information and making it more work
+ * to specify.
+ *
+ * It is possible to give constructor fields values that aren't field names. If

[justinfagnani, 2012/11/20 02:05:30]

I don't understand this paragraph.

[Alan Knight, 2012/11/20 15:03:54]

Rewrote. It's a bit of a bells and whistles feature, but something I needed for
the meta-serialization.

+ * any value isn't a String, it will be treated as a constant. This allows you
+ * to provide constant values to a constructor that aren't obtained from fields.
+ *
+ * In some cases a non-constructor field should not be set using field
+ * access or a setter, but should be done by calling a method. For example, it
+ * may not be possible to set a List field "foo", and you need to call an
+ * addFoo() method for each entry in the list. In these cases, if you are using
+ * a BasicRule for the object you can call the specialTreatmentFor() method.
+ *
+ *       s..addRuleFor(fooHolderInstance).specialTreatmentFor("foo",

[justinfagnani, 2012/11/20 02:05:30]

I feel like "specialTreatementFor" is pretty long and doesn't denote that the
treatment is for a field, which is important because the types don't indicate
that either. How about something like handleField()?

[Alan Knight, 2012/11/20 15:03:54]

I agree it's too long. But handleField() seems very vague. Maybe specialField()?
customField()? I figured the parameter being called fieldName was enough
indication of what was expected, but certainly don't mind including "field" in
the name.

+ *           (parent, value) => for (var each in value) parent.addFoo(value));
+ *
+ * Writing
+ * =======
+ * To write objects, we use the write() methods. There are two variations.
+ *
+ *       String output = serialization.write(someObject);
+ *       List output = serialization.writeFlat(someObject);
+ *
+ * The first uses a representation in which objects are represented as maps
+ * keyed by field name, but in which references between objects have been
+ * converted into Reference objects. This is then encoded as a JSON string.
+ *
+ * The second representation holds all the objects as a List of simple types.
+ * For practical use you may want to convert that to a JSON or other encoded
+ * representation as well.
+ *
+ * Both representations are primarily intended as proofs of concept for
+ * different types of representation, and we expect to generalize that to a
+ * pluggable mechanism for different representations.
+ *
+ * Reading
+ * =======
+ * To read objects, the corresponding methods are [read] and [readFlat].
+ *
+ *       List input = serialization.read(aString);
+ *       List input = serialization.readFlat(aList);

[justinfagnani, 2012/11/20 02:05:30]

Does this return a List of Lists? From the description of writeFlat above it
sounds like a single object can be written to a list, so multiple objects would
be written to nested lists.

[Alan Knight, 2012/11/20 15:03:54]

No, it returns a list of the roots that were written. I think the whole thing
around single and multiple objects is confusing, and am leaning towards always
having a single root so read/write methods just return one object. If you want
multiples, give it a List as the root. Thoughts?

+ *
+ * There is also a convenience method for the case of reading a single object.

[justinfagnani, 2012/11/20 02:05:30]

Are there corresponding methods to write multiple objects?

[Alan Knight, 2012/11/20 15:03:54]

See above.

+ *
+ *       Object result = serialization.readOne(aString);
+ *       Object result = serialization.readOneFlat(aString);

[justinfagnani, 2012/11/20 02:05:30]

For multiple objects it would be great to have the equivalent of Java's
ObjectInputStream and ObjectOutputStream.

[Alan Knight, 2012/11/20 15:03:54]

If the objects written/read are entirely independent then it seems like it would
be pretty straightforward, especially with the new streaming stuff.

+ *
+ * When reading, the serialization instance doing the reading must be configured
+ * with compatible rules to the one doing the writing. It's possible for the
+ * rules to be different, but they need to be able to read the same
+ * representation. For most practical purposes right now they should be the
+ * same. The simplest way to achieve this is by having the serialization
+ * variable [selfDescribing] be true. In that case the rules themselves are also
+ * stored along with the serialized data, and can be read back on the receiving
+ * end. Note that this does not yet work for [ClosureToMapRule]. The
+ * [selfDescribing] variable is true by default.
+ *
+ * When reading, some object references should not be serialized, but should be

[justinfagnani, 2012/11/20 02:05:30]

Why wouldn't this be done with a custom rule for that type? The rule can
serialize the external object with the info needed to resolve it on the
receiver, and the receiver and then resolve it however it needs to. This could
be done with mirrors or without depending on the situation/environment.

[Alan Knight, 2012/11/20 15:03:54]

It's not by type, but by instance. Or at least potentially by instance. This
Person should be de-serialized, but that one should be looked up in the session.
So you shouldn't even need a custom rule for it. I'm thinking that the
appropriate generalization, at least for the easy cases, is that on write you
also can provide a dictionary mapping from instances to names, and any instances
on that list get mapped to the appropriate name. In cases where it should apply
to a whole type a custom rule would work.

This particular rule doesn't actually use mirrors, it's used in order to
de-serialize references to mirrors. Which is more confusing than it needs to be,
it was just done that way because that was the initial use case I had. This
support definitely needs to be generalized, and there are TODOs for that in
here.

+ * connected up to other instances on the receiving side. A notable example of
+ * this is when serialization rules have been stored. Instances of BasicRule
+ * take a [ClassMirror] in their constructor, and we cannot serialize those. So
+ * when we read the rules, we must provide a Map<String, Object> which maps from
+ * the simple name of classes we are interested in to a [ClassMirror]. This can
+ * be provided either in the [externalObjects] variable of the Serialization,
+ * or as an additional parameter to the reading methods.
+ *
+ *     new Serialization()
+ *       ..addRuleFor(new Person(), constructorFields: ["name"])
+ *       ..externalObjects['Person'] = reflect(new Person()).type;
+ */
+library serialization;
+
+import 'src/mirrors_helpers.dart';

[justinfagnani, 2012/11/20 02:05:30]

I think we're supposed to use package: urls even for internal imports. Maybe
double check w/ someone in SEA though.

[Alan Knight, 2012/11/20 15:03:54]

We weren't for stuff in the SDK, because the bots can't handle them. But the CL
to fix that is in review, so hopefully very soon now it'll work.

+import 'src/serialization_helpers.dart';
+//import 'src/polyfill_identity_set.dart';

[justinfagnani, 2012/11/20 02:05:30]

remove

[Alan Knight, 2012/11/20 15:03:54]

Done.

+import 'src/polyfill_identity_set.dart';
+import 'dart:json';
+
+part 'src/reader_writer.dart';
+part 'src/serialization_rule.dart';
+part 'src/basic_rule.dart';
+
+/**
+ * This class defines a particular serialization scheme, in terms of
+ * [SerializationRule] instances, and supports reading and writing them.
+ * See library comment for examples of usage.
+ */
+class Serialization {
+
+  /**
+   * The serialization is controlled by the list of Serialization rules. These
+   * are most commonly added via [addRuleFor].
+   */
+  List rules = [];
+
+  /**
+   * When reading, we may need to resolve references to existing objects in
+   * the system. The right action may not be to create a new instance of
+   * something, but rather to find an existing instance and connect to it.
+   * For example, if we have are serializing an Email message and it has a
+   * link to the owning account, it may not be appropriate to try and serialize
+   * the account. Instead we should just connect the de-serialized message
+   * object to the account object that already exists there.
+   */
+  Map<String, dynamic> externalObjects = {};
+
+  /**
+   * When we write out data using this serialization, should we also write
+   * out a description of the rules.
+   */
+  bool selfDescribing = true;
+
+  /**
+   * Creates a new serialization with a default set of rules for primitives
+   * and lists.
+   */
+  Serialization() {
+    _addDefaultRules();
+  }
+
+  /**
+   * Creates a new serialization with no default rules at all. The most common
+   * use for this is if we are reading self-describing serialized data and
+   * will populate the rules from that data.
+   */
+  Serialization.blank() { }
+
+  /**
+   * Create a [BasicRule] rule for the type of
+   * [instanceOfType]. Optionally
+   * allows specifying a [constructor] name, the list of [constructorFields],
+   * and the list of [fields] not used in the constructor. Returns the new
+   * rule.
+   *
+   * If the optional parameters aren't specified, the default constructor will
+   * be used, and the list of fields will be computed. Alternatively, you can
+   * omit [fields] and provide [excludeFields], which will then compute the
+   * list of fields specifically excluding those listed.
+   *
+   * The fields can be actual public fields, but can also be getter/setter
+   * pairs or getters whose value is provided in the constructor. For the
+   * [constructorFields] they can also be arbitrary objects. Anything that is
+   * not a String will be treated as a constant value to be used in any
+   * construction of these objects.
+   *
+   * If the list of fields is computed, fields from the superclass will be
+   * included. However, each subclass needs its own rule, since the constructors
+   * are not inherited, and so may need to be specified separately for each
+   * subclass.
+   */
+  // TODO(alanknight): Take a type rather than an instance. Issue 6282.

[justinfagnani, 2012/11/20 02:05:30]

Can you still take a type and require that callers use .runtimeType() to get
one?

[Alan Knight, 2012/11/20 15:03:54]

Sadly, no. Checked to see if there was a bug for that and didn't see anything,
so added that to 6433.

+  BasicRule addRuleFor(
+      instanceOfType,
+      {String constructor,
+        List constructorFields,
+        List<String> fields,
+        List<String> excludeFields}) {
+
+    var rule;
+    rule = new BasicRule(
+        turnInstanceIntoSomethingWeCanUse(
+            instanceOfType),
+        constructor, constructorFields, fields, excludeFields);
+    addRule(rule);
+    return rule;
+  }
+
+  /** By default we have rules for lists and primitives pre-populated. */
+  void _addDefaultRules() {
+    addRule(new PrimitiveRule());
+    addRule(new ListRule());
+    // Both these rules apply to lists, so unless otherwise indicated,
+    // it will always find the first one.
+    addRule(new ListRuleEssential());
+  }
+
+  /**
+   * Add a new SerializationRule [rule]. The addRuleFor method will probably
+   * handle most simple cases, but for adding an arbitrary rule, including
+   * a SerializationRule subclass which you have created, you can use this
+   * method.
+   */
+  void addRule(SerializationRule rule) {
+    rule.number = rules.length;
+    rules.add(rule);
+  }
+
+  /**
+   * This is the basic method to write out an object graph rooted at
+   * [object] and return the result. Right now this is hard-coded to return
+   * a String from a custom JSON format, but that is likely to change to be
+   * more pluggable in the near future.
+   */
+  String write(Object object) {
+    return newWriter().write(object);
+  }
+
+  /**
+   * Return a new [Writer] object for this serialization. This is useful if you
+   * want to do something more complex with the writer than just returning
+   * the final result.
+   */
+  Writer newWriter() => new Writer(this);
+
+  /**
+   * Write out the tree in a custom flat format, returning a list containing
+   * only "simple" types: num, String, and bool.
+   */
+  List writeFlat(Object object) {
+    return newWriter().writeFlat(object);
+  }
+
+  /**
+   * Read the serialized data from [input] and return a List of the root
+   * objects from the result. If there are objects that need to be resolved
+   * in the current context, they should be provided in [externals] as a
+   * Map from names to values. In particular, in the current implementation
+   * any class mirrors needed should be provided in [externals] using the
+   * class name as a key. In addition to the [externals] map provided here,
+   * values will be looked up in the [externalObjects] map.
+   */
+  List read(String input, [Map externals = const {}]) {
+    return newReader().read(input, externals);
+  }
+
+  /**
+   * In the most common case there is only a single root object to be read,
+   * and this method can be used to return just one object rather than
+   * a List. The [input] and [externals] parameters are the same as for the
+   * general [read] method.
+   */
+  Object readOne(String input, [Map externals = const {}]) {
+    return newReader().readOne(input, externals);
+  }
+
+  /**
+   * Return a new [Reader] object for this serialization. This is useful if
+   * you want to do something more complex with the reader than just returning
+   * the final result.
+   */
+  Reader newReader() => new Reader(this);
+
+  /**
+   * Return the list of SerializationRule that apply to [object]. For
+   * internal use, but public because it's used in testing.
+   */
+  List<SerializationRule> rulesFor(object) {
+    // This has a couple of edge cases.
+    // 1) The owning object may have indicated we should use a different
+    // rule than the default.
+    // 2) We may not have a rule, in which case we lazily create a BasicRule.
+    // 3) Rules are allowed to say mustBePrimary, meaning that they can be used
+    // iff no other rule was chosen first.
+    // TODO(alanknight): Can the mustBePrimary mechanism be removed or changed.
+    // It adds an order dependency to the rules, and is messy. Reconsider in the
+    // light of a more general mechanism for multiple rules per object.
+    // TODO(alanknight): Finding which rules apply seems likely to be a
+    // bottleneck, particularly with the current reflective implementation.
+    // Consider how to improve it. e.g. cache the list of rules by class. But
+    // be careful of issues like rules which have arbitrary predicates. Or
+    // consider having the arbitrary predicates be secondary to an initial
+    // class-based lookup mechanism.
+    var target, candidateRules;
+    if (object is DesignatedRuleForObject) {
+      target = object.target;
+      candidateRules = object.possibleRules(rules);
+    } else {
+      target = object;
+      candidateRules = rules;
+    }
+    List applicable = candidateRules.filter((each) => each.appliesTo(target));
+
+    if (applicable.isEmpty) {
+      return [addRuleFor(target)];
+    }
+
+    if (applicable.length == 1) return applicable;
+    var first = applicable[0];
+    var finalRules = applicable.filter(
+        (x) => !x.mustBePrimary || (x == first));
+
+    if (finalRules.isEmpty) throw new SerializationException(
+        'No valid rule found for object $object');
+    return finalRules;
+  }
+
+  /**
+   * Create a Serialization for serializing SerializationRules. This is used
+   * to save the rules in a self-describing format along with the data.
+   * If there are new rule classes created, they will need to be described
+   * here.
+   */
+  Serialization _ruleSerialization() {
+    // TODO(alanknight): There's an extensibility issue here with new rules.
+    // TODO(alanknight): How to handle rules with closures? They have to
+    // exist on the other side, but we might be able to hook them up by name,
+    // or we might just be able to validate that they're correctly set up
+    // on the other side.
+
+    // Make some bogus rule instances so we have something to feed rule creation
+    // and get their types. If only we had class literals implemented...
+    var closureRule = new ClosureToMapRule.stub([].runtimeType);
+    var basicRule = new BasicRule(reflect(null).type, '', [], [], []);
+
+    var meta = new Serialization()
+      ..selfDescribing = false
+      ..addRuleFor(new ListRule())
+      ..addRuleFor(new PrimitiveRule())
+      ..addRuleFor(new ListRuleEssential())
+      ..addRuleFor(basicRule,
+          constructorFields: ['typeWrapped',
+            'constructorName',
+            'constructorFields', 'regularFields', []],
+          fields: [])
+      ..addRule(new ClassMirrorRule());
+    meta.externalObjects = externalObjects;
+    return meta;
+  }
+}
+
+/**
+ * An exception class for errors during serialization.
+ */
+class SerializationException implements Exception {
+  final String message;
+  const SerializationException([this.message]);
+}