Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(559)

Issue 11293235: Ensure that NSS HTTP IO is initialized on iOS. (Closed)

Created:
8 years, 1 month ago by blundell
Modified:
8 years, 1 month ago
Reviewers:
Ryan Sleevi
CC:
chromium-reviews, cbentzel+watch_chromium.org, darin-cc_chromium.org, droger
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Ensure that NSS HTTP IO is initialized on iOS. |EnsureNSSHttpIOInit| was not being called on iOS. Previously this had been OK because |SetMessageLoopForNSSHttpIO| is being called on iOS. However, after the landing of http://crrev.com/127680, |SetMessageLoopForNSSHttpIO| no longer actually sets the IO loop used for NSS HTTP IO. To remedy this problem, ensure that |EnsureNSSHttpIOInit| is called on iOS. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=167328

Patch Set 1 #

Total comments: 2

Patch Set 2 : Response to review #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M net/socket/ssl_client_socket_nss.cc View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (0 generated)
blundell
8 years, 1 month ago (2012-11-12 21:34:07 UTC) #1
Ryan Sleevi
LGTM, mod nit. https://chromiumcodereview.appspot.com/11293235/diff/1/net/socket/ssl_client_socket_nss.cc File net/socket/ssl_client_socket_nss.cc (right): https://chromiumcodereview.appspot.com/11293235/diff/1/net/socket/ssl_client_socket_nss.cc#newcode3097 net/socket/ssl_client_socket_nss.cc:3097: #if (!defined(OS_MACOSX) && !defined(OS_WIN)) || defined(OS_IOS) ...
8 years, 1 month ago (2012-11-12 21:45:45 UTC) #2
blundell
Thanks. https://chromiumcodereview.appspot.com/11293235/diff/1/net/socket/ssl_client_socket_nss.cc File net/socket/ssl_client_socket_nss.cc (right): https://chromiumcodereview.appspot.com/11293235/diff/1/net/socket/ssl_client_socket_nss.cc#newcode3097 net/socket/ssl_client_socket_nss.cc:3097: #if (!defined(OS_MACOSX) && !defined(OS_WIN)) || defined(OS_IOS) On 2012/11/12 ...
8 years, 1 month ago (2012-11-12 21:58:44 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/blundell@chromium.org/11293235/2003
8 years, 1 month ago (2012-11-12 21:59:35 UTC) #4
commit-bot: I haz the power
Step "update" is always a major failure. Look at the try server FAQ for more ...
8 years, 1 month ago (2012-11-13 03:52:33 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/blundell@chromium.org/11293235/2003
8 years, 1 month ago (2012-11-13 07:58:25 UTC) #6
commit-bot: I haz the power
8 years, 1 month ago (2012-11-13 08:19:11 UTC) #7
Change committed as 167328

Powered by Google App Engine
This is Rietveld 408576698