Android: correctly generates inner class from import clause.

Android: correctly generates inner class from import clause.

After r166482, it started deriving the JNI parameters from the "import" clause.
However, for "import foo.Outer.Inner", it'd generate "Lfoo/Outer/Inner" rather
than "Lfoo/Outer$Inner".

BUG=
TEST=build/android/jni_generator/jni_generator_tests.py


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=167384

[bulach, 2012-11-09 20:21:01]

ptal

[digit1, 2012-11-12 09:18:16]

lgtm :)

[Miguel Garcia, 2012-11-12 09:23:20]

lgtm

Great catch!

[bulach, 2012-11-12 12:08:05]

new patchet uploaded: it now forbids import pkg.Outer.Inner and using Inner
directly in JNI. instead, it requires import pkg.Outer and using Outer.Inner.. 
ptal!

[joth, 2012-11-12 21:22:07]

lgtm

http://codereview.chromium.org/11293206/diff/1003/base/android/jni_generator/...
File base/android/jni_generator/jni_generator.py (right):

http://codereview.chromium.org/11293206/diff/1003/base/android/jni_generator/...
base/android/jni_generator/jni_generator.py:178: # Is it Bar from import
zoo.foo.Bar ?
nit: Is it from an inner class import? (e.g. import zoo.Outer.Inner)

http://codereview.chromium.org/11293206/diff/1003/base/android/jni_generator/...
base/android/jni_generator/jni_generator.py:190: # Is it an inner class
zoo.Foo.Bar from import zoo.Foo?
Is it an inner class from an outer class import? (e.g. referencing Outer.Inner
from import zoo.Outer).

[bulach, 2012-11-12 22:10:19]

thanks joth! I'll put through the CQ and follow up should anyone else have
further comments.

http://codereview.chromium.org/11293206/diff/1003/base/android/jni_generator/...
File base/android/jni_generator/jni_generator.py (right):

http://codereview.chromium.org/11293206/diff/1003/base/android/jni_generator/...
base/android/jni_generator/jni_generator.py:178: # Is it Bar from import
zoo.foo.Bar ?
On 2012/11/12 21:22:07, joth wrote:
> nit: Is it from an inner class import? (e.g. import zoo.Outer.Inner)

Done.

http://codereview.chromium.org/11293206/diff/1003/base/android/jni_generator/...
base/android/jni_generator/jni_generator.py:190: # Is it an inner class
zoo.Foo.Bar from import zoo.Foo?
On 2012/11/12 21:22:07, joth wrote:
> Is it an inner class from an outer class import? (e.g. referencing Outer.Inner
> from import zoo.Outer).

Done.

[commit-bot: I haz the power, 2012-11-12 22:10:37]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/bulach@chromium.org/11293206/6

[commit-bot: I haz the power, 2012-11-13 03:55:08]

Step "update" is always a major failure.
Look at the try server FAQ for more details.

[commit-bot: I haz the power, 2012-11-13 14:30:38]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/bulach@chromium.org/11293206/6

[commit-bot: I haz the power, 2012-11-13 14:35:03]

Change committed as 167384