Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(661)

Issue 11293198: Fix handling of spaces with paths in copy_test_data.py (Closed)

Created:
8 years, 1 month ago by stuartmorgan
Modified:
8 years, 1 month ago
CC:
chromium-reviews
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Fix handling of spaces with paths in copy_test_data.py This allows copying files with spaces in the paths (most notably, profiles, which have a number of files containing spaces). There are two fixes: - Input/output lists \-escape spaces so that gyp will convert the output back into a list correctly. - The argument list is no longer parsed by spaces, and the gyp call instead passes the input list as a list of separate arguments instead of one giant string. BUG=None Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=166931

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -8 lines) Patch
M build/copy_test_data_ios.gypi View 1 chunk +1 line, -1 line 0 comments Download
M build/copy_test_data_ios.py View 3 chunks +9 lines, -7 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
stuartmorgan
8 years, 1 month ago (2012-11-09 15:45:54 UTC) #1
rohitrao (ping after 24h)
lgtm
8 years, 1 month ago (2012-11-09 15:54:09 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/stuartmorgan@chromium.org/11293198/1
8 years, 1 month ago (2012-11-09 15:55:19 UTC) #3
commit-bot: I haz the power
8 years, 1 month ago (2012-11-09 18:04:51 UTC) #4
Change committed as 166931

Powered by Google App Engine
This is Rietveld 408576698