Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(248)

Issue 11293188: cc: Make Picture/PicturePile handle recording/raster (Closed)

Created:
8 years, 1 month ago by enne (OOO)
Modified:
8 years, 1 month ago
Reviewers:
nduca, slavi
CC:
chromium-reviews, cc-bugs_chromium.org
Visibility:
Public.

Description

cc: Make Picture/PicturePile handle recording/raster It's not efficient (or tested), but this should be enough to start being useful once we add the raster/upload/appendQuads path. Next steps are probably to add tilings to the PictureLayerImpl. R=nduca@chromium.org BUG=155209 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=166999

Patch Set 1 #

Patch Set 2 : Rebased #

Patch Set 3 : Fix win_rel #

Patch Set 4 : Chromium style variable names #

Patch Set 5 : Fix win_rel. Again. #

Total comments: 1

Patch Set 6 : FULL STOP #

Patch Set 7 : Fix android_dbg #

Patch Set 8 : Fix android_dbg #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+230 lines, -28 lines) Patch
M cc/picture.h View 1 2 3 1 chunk +21 lines, -8 lines 0 comments Download
M cc/picture.cc View 1 2 3 1 chunk +67 lines, -1 line 2 comments Download
M cc/picture_layer.h View 1 2 2 chunks +6 lines, -0 lines 0 comments Download
M cc/picture_layer.cc View 1 2 3 2 chunks +17 lines, -3 lines 0 comments Download
M cc/picture_layer_impl.h View 1 2 3 4 5 2 chunks +8 lines, -0 lines 0 comments Download
M cc/picture_layer_impl.cc View 1 chunk +13 lines, -0 lines 0 comments Download
M cc/picture_pile.h View 1 2 3 2 chunks +16 lines, -8 lines 0 comments Download
M cc/picture_pile.cc View 1 2 3 4 5 6 2 chunks +82 lines, -8 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
enne (OOO)
8 years, 1 month ago (2012-11-08 23:35:24 UTC) #1
enne (OOO)
This also depends on a few extra functions in cc::Region, which I will put a ...
8 years, 1 month ago (2012-11-08 23:35:47 UTC) #2
nduca
lgtm https://codereview.chromium.org/11293188/diff/8002/cc/picture_layer_impl.h File cc/picture_layer_impl.h (right): https://codereview.chromium.org/11293188/diff/8002/cc/picture_layer_impl.h#newcode24 cc/picture_layer_impl.h:24: // LayerImpl overrides overrides.
8 years, 1 month ago (2012-11-09 19:34:51 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/enne@chromium.org/11293188/6009
8 years, 1 month ago (2012-11-09 19:50:45 UTC) #4
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
8 years, 1 month ago (2012-11-09 20:04:29 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/enne@chromium.org/11293188/6009
8 years, 1 month ago (2012-11-09 20:31:53 UTC) #6
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
8 years, 1 month ago (2012-11-09 20:38:58 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/enne@chromium.org/11293188/12002
8 years, 1 month ago (2012-11-09 20:41:24 UTC) #8
commit-bot: I haz the power
Change committed as 166999
8 years, 1 month ago (2012-11-09 22:37:11 UTC) #9
slavi
https://codereview.chromium.org/11293188/diff/12002/cc/picture.cc File cc/picture.cc (right): https://codereview.chromium.org/11293188/diff/12002/cc/picture.cc#newcode78 cc/picture.cc:78: canvas->save(); No need to save/resore here. See comment of ...
8 years, 1 month ago (2012-11-09 23:56:20 UTC) #10
enne (OOO)
8 years, 1 month ago (2012-11-09 23:59:20 UTC) #11

Powered by Google App Engine
This is Rietveld 408576698