Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(276)

Issue 11293170: Fix findbugs_diff in ContentVideoView.java. (Closed)

Created:
8 years, 1 month ago by Philippe
Modified:
8 years, 1 month ago
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam
Visibility:
Public.

Description

Fix findbugs_diff in ContentVideoView.java. Findbugs was emitting: M P SIC: Should org.chromium.content.browser.ContentVideoView$FullScreenMediaController be a _static_ inner class? At ContentVideoView.java NOTRY=true TEST=findbugs_diff.py Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=166675

Patch Set 1 #

Patch Set 2 : Update expectation file #

Patch Set 3 : Sync #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -3 lines) Patch
M build/android/findbugs_filter/findbugs_known_bugs.txt View 1 1 chunk +0 lines, -1 line 0 comments Download
M content/public/android/java/src/org/chromium/content/browser/ContentVideoView.java View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
Philippe
8 years, 1 month ago (2012-11-08 13:15:09 UTC) #1
Philippe
On 2012/11/08 13:15:09, Philippe wrote: FYI, I'm preparing a second patch set to update the ...
8 years, 1 month ago (2012-11-08 13:17:10 UTC) #2
Philippe
Done.
8 years, 1 month ago (2012-11-08 13:19:10 UTC) #3
John Knottenbelt
lgtm
8 years, 1 month ago (2012-11-08 13:19:45 UTC) #4
Philippe
I think that I need your approval Marcus :)
8 years, 1 month ago (2012-11-08 13:25:31 UTC) #5
bulach
lgtm, thanks!
8 years, 1 month ago (2012-11-08 14:01:47 UTC) #6
Philippe
On 2012/11/08 14:01:47, bulach wrote: > lgtm, thanks! Thanks Marcus! Note that the failure on ...
8 years, 1 month ago (2012-11-08 14:02:49 UTC) #7
Philippe
On 2012/11/08 14:02:49, Philippe wrote: > On 2012/11/08 14:01:47, bulach wrote: > > lgtm, thanks! ...
8 years, 1 month ago (2012-11-08 14:08:02 UTC) #8
Philippe
On 2012/11/08 14:08:02, Philippe wrote: > On 2012/11/08 14:02:49, Philippe wrote: > > On 2012/11/08 ...
8 years, 1 month ago (2012-11-08 14:13:49 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pliard@chromium.org/11293170/9001
8 years, 1 month ago (2012-11-08 14:30:45 UTC) #10
commit-bot: I haz the power
8 years, 1 month ago (2012-11-08 14:30:54 UTC) #11
Change committed as 166675

Powered by Google App Engine
This is Rietveld 408576698