Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(99)

Issue 11293168: Rename kAsciiStringTag to kOneByteStringTag (Closed)

Created:
8 years, 1 month ago by drcarney
Modified:
8 years, 1 month ago
Reviewers:
Yang
CC:
v8-dev
Visibility:
Public.

Description

Rename kAsciiStringTag to kOneByteStringTag This is just a rename. After commit, I'll begin with the semantic changes. Until those are complete, kOneByteStringTag will have the same meaning as kAsciiStringTag. BUG= Committed: https://code.google.com/p/v8/source/detail?r=12897

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+66 lines, -65 lines) Patch
M src/arm/code-stubs-arm.cc View 4 chunks +6 lines, -6 lines 0 comments Download
M src/arm/macro-assembler-arm.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/ia32/code-stubs-ia32.cc View 4 chunks +6 lines, -6 lines 0 comments Download
M src/ia32/codegen-ia32.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/ia32/full-codegen-ia32.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/ia32/macro-assembler-ia32.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M src/mips/code-stubs-mips.cc View 4 chunks +7 lines, -6 lines 0 comments Download
M src/mips/macro-assembler-mips.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/objects.h View 2 chunks +10 lines, -10 lines 0 comments Download
M src/objects.cc View 6 chunks +6 lines, -6 lines 0 comments Download
M src/objects-inl.h View 7 chunks +12 lines, -12 lines 0 comments Download
M src/objects-visiting.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/x64/code-stubs-x64.cc View 4 chunks +6 lines, -6 lines 0 comments Download
M src/x64/codegen-x64.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/x64/full-codegen-x64.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M src/x64/macro-assembler-x64.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M tools/gen-postmortem-metadata.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 1 (0 generated)
Yang
8 years, 1 month ago (2012-11-08 11:56:55 UTC) #1
LGTM.

Powered by Google App Engine
This is Rietveld 408576698