Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Issue 11293147: Always add 100P scale format in the supported format list. (Closed)

Created:
8 years, 1 month ago by noyau (Ping after 24h)
Modified:
8 years, 1 month ago
CC:
chromium-reviews, rsesek+watch_chromium.org
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Always add 100P scale format in the supported format list. Align iOS with the other platforms and add 100P to the list of supported scale formats. BUG=None Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=167165

Patch Set 1 #

Total comments: 1

Patch Set 2 : Adding TODO. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -43 lines) Patch
M ui/base/layout.cc View 1 1 chunk +5 lines, -5 lines 0 comments Download
M ui/base/resource/resource_bundle_ios.mm View 1 chunk +1 line, -4 lines 0 comments Download
M ui/gfx/image/image_ios.mm View 1 chunk +1 line, -8 lines 0 comments Download
M ui/gfx/image/image_skia_util_ios.mm View 1 2 chunks +3 lines, -18 lines 0 comments Download
M ui/gfx/image/image_unittest_util.cc View 1 chunk +1 line, -8 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
noyau (Ping after 24h)
To rohitrao for initial review.
8 years, 1 month ago (2012-11-07 13:42:36 UTC) #1
rohitrao (ping after 24h)
LGTM I'm not very happy with this CL, since it forces us to carry around ...
8 years, 1 month ago (2012-11-09 14:27:53 UTC) #2
noyau (Ping after 24h)
To thakis for owner review. Note that this CL only changes iOS code and has ...
8 years, 1 month ago (2012-11-09 15:23:33 UTC) #3
Nico
What do you need this for? The CL description doesn't say, and there's nothing in ...
8 years, 1 month ago (2012-11-09 17:53:36 UTC) #4
Nico
lgtm with a comment that explains why you need 1x on retina ios devices. If ...
8 years, 1 month ago (2012-11-09 19:16:37 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/noyau@chromium.org/11293147/7003
8 years, 1 month ago (2012-11-12 10:53:26 UTC) #6
commit-bot: I haz the power
8 years, 1 month ago (2012-11-12 12:31:13 UTC) #7
Change committed as 167165

Powered by Google App Engine
This is Rietveld 408576698