Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(103)

Issue 11293084: cc: Get rid of FloatToSkScalar() function. (Closed)

Created:
8 years, 1 month ago by tfarina
Modified:
8 years, 1 month ago
Reviewers:
danakj, enne (OOO)
CC:
chromium-reviews, cc-bugs_chromium.org
Visibility:
Public.

Description

cc: Get rid of FloatToSkScalar() function. Accordding to Dana: "We can probably just call SkFloatToScalar directly in those sites. Those values should never be NaN or infinity." BUG=147395 TEST=cc_unittests R=enne@chromium.org,danakj@chromium.org NOTRY=true Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=165889

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -40 lines) Patch
M cc/cc.gyp View 2 chunks +0 lines, -2 lines 0 comments Download
M cc/content_layer_updater.cc View 3 chunks +3 lines, -3 lines 0 comments Download
D cc/stubs/SkiaUtils.h View 1 chunk +0 lines, -6 lines 0 comments Download
D cc/stubs/skia_utils.h View 1 chunk +0 lines, -29 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
tfarina
8 years, 1 month ago (2012-11-03 21:08:27 UTC) #1
enne (OOO)
lgtm lgtm I have no idea why that even existed in the first place.
8 years, 1 month ago (2012-11-03 21:09:52 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tfarina@chromium.org/11293084/1
8 years, 1 month ago (2012-11-04 13:02:45 UTC) #3
commit-bot: I haz the power
8 years, 1 month ago (2012-11-05 01:51:40 UTC) #4
Change committed as 165889

Powered by Google App Engine
This is Rietveld 408576698