Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(389)

Side by Side Diff: chrome/browser/page_cycler/page_cycler_browsertest.cc

Issue 11293067: PageCyclerCachedBrowserTest.PlaybackMode fails randomly on Linux debug and release (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/command_line.h" 5 #include "base/command_line.h"
6 #include "base/file_path.h" 6 #include "base/file_path.h"
7 #include "base/file_util.h" 7 #include "base/file_util.h"
8 #include "base/path_service.h" 8 #include "base/path_service.h"
9 #include "base/string_split.h" 9 #include "base/string_split.h"
10 #include "base/string_util.h" 10 #include "base/string_util.h"
(...skipping 299 matching lines...) Expand 10 before | Expand all | Expand 10 after
310 310
311 ASSERT_FALSE(errors[0].compare(expected_error)); 311 ASSERT_FALSE(errors[0].compare(expected_error));
312 } 312 }
313 313
314 // Test that PageCycler will visit all the urls from a cache directory 314 // Test that PageCycler will visit all the urls from a cache directory
315 // successfully while in playback mode. 315 // successfully while in playback mode.
316 #if defined(OS_CHROMEOS) 316 #if defined(OS_CHROMEOS)
317 // TODO(rdevlin.cronin): Perhaps page cycler isn't completely implemented on 317 // TODO(rdevlin.cronin): Perhaps page cycler isn't completely implemented on
318 // ChromeOS? 318 // ChromeOS?
319 #else 319 #else
320 #if (defined(OS_WIN) || defined(OS_MACOSX) || defined(OS_LINUX)) && \ 320 #if defined(OS_LINUX)
321 !defined(NDEBUG) 321 // Bug 159026: Randomly fails on Linux release and debug.
322 #define MAYBE_PlaybackMode DISABLED_PlaybackMode
323 #else
324 #if (defined(OS_WIN) || defined(OS_MACOSX)) && !defined(NDEBUG)
322 // Bug 131333: This test fails on a XP debug bot since Build 17609. 325 // Bug 131333: This test fails on a XP debug bot since Build 17609.
323 // Bug 159026: Also fails on Linux debug bot.
324 #define MAYBE_PlaybackMode DISABLED_PlaybackMode 326 #define MAYBE_PlaybackMode DISABLED_PlaybackMode
325 #else 327 #else
326 #define MAYBE_PlaybackMode PlaybackMode 328 #define MAYBE_PlaybackMode PlaybackMode
327 #endif 329 #endif
328 IN_PROC_BROWSER_TEST_F(PageCyclerCachedBrowserTest, MAYBE_PlaybackMode) { 330 IN_PROC_BROWSER_TEST_F(PageCyclerCachedBrowserTest, MAYBE_PlaybackMode) {
329 ScopedTempDir temp; 331 ScopedTempDir temp;
330 ASSERT_TRUE(temp.CreateUniqueTempDir()); 332 ASSERT_TRUE(temp.CreateUniqueTempDir());
331 333
332 RegisterForNotifications(); 334 RegisterForNotifications();
333 InitFilePaths(temp.path()); 335 InitFilePaths(temp.path());
(...skipping 46 matching lines...) Expand 10 before | Expand all | Expand 10 after
380 ASSERT_EQ(1u, errors.size()); 382 ASSERT_EQ(1u, errors.size());
381 383
382 std::string expected_error; 384 std::string expected_error;
383 expected_error.append("Failed to load the page at: ") 385 expected_error.append("Failed to load the page at: ")
384 .append(kCacheMissURL) 386 .append(kCacheMissURL)
385 .append(": The requested entry was not found in the cache."); 387 .append(": The requested entry was not found in the cache.");
386 388
387 ASSERT_FALSE(errors[0].compare(expected_error)); 389 ASSERT_FALSE(errors[0].compare(expected_error));
388 } 390 }
389 #endif 391 #endif
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698