Issue 11293025: Fix site_instance DCHECK when loading restored tabs.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11293025: Fix site_instance DCHECK when loading restored tabs. (Closed)

Created:
8 years, 1 month ago by Ted C

Modified:
8 years, 1 month ago

Reviewers:
Jay Civelli

CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Fix site_instance DCHECK when loading restored tabs. Reload does not call the proper initialization bits required to bring the navigation_entries back to life. Need to call LoadIfNecessary() as called in session_restore (TabLoader::LoadNextTab) on desktop. BUG= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=165472

Patch Set 1 #

Patch Set 2 : Rebased #

Created: 8 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -1 line)			Patch
	M	content/browser/android/content_view_core_impl.cc	View		1 chunk	+4 lines, -1 line	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tedchoc@chromium.org/11293025/1

8 years, 1 month ago (2012-10-31 22:42:18 UTC) #3

commit-bot: I haz the power

Step "update" is always a major failure. Look at the try server FAQ for more ...

8 years, 1 month ago (2012-11-01 04:51:02 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tedchoc@chromium.org/11293025/10001

8 years, 1 month ago (2012-11-01 17:17:05 UTC) #5

Change committed as 165472

Expand Messages | Collapse Messages