Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1128933011: Start passing Title text with the context menu data. (Closed)

Created:
5 years, 7 months ago by aurimas (slooooooooow)
Modified:
5 years, 7 months ago
Reviewers:
esprehn, dglazkov
CC:
blink-reviews, dglazkov+blink
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Start passing Title text with the context menu data. BUG=487782 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=195432

Patch Set 1 #

Patch Set 2 : Switch to using Title attribute first #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -0 lines) Patch
M Source/web/ContextMenuClientImpl.cpp View 1 1 chunk +9 lines, -0 lines 0 comments Download
M public/web/WebContextMenuData.h View 1 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (5 generated)
aurimas (slooooooooow)
esprehn: PTAL
5 years, 7 months ago (2015-05-15 21:35:29 UTC) #2
esprehn
lgtm
5 years, 7 months ago (2015-05-16 01:04:45 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1128933011/20001
5 years, 7 months ago (2015-05-16 01:18:53 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: blink_presubmit on tryserver.blink (JOB_FAILED, http://build.chromium.org/p/tryserver.blink/builders/blink_presubmit/builds/33292)
5 years, 7 months ago (2015-05-16 01:23:55 UTC) #7
aurimas (slooooooooow)
dglazkov: PTAL
5 years, 7 months ago (2015-05-16 02:05:08 UTC) #9
dglazkov
Whoa XKCD fix. LGTM.
5 years, 7 months ago (2015-05-16 02:31:45 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1128933011/20001
5 years, 7 months ago (2015-05-16 02:34:29 UTC) #12
commit-bot: I haz the power
5 years, 7 months ago (2015-05-16 02:48:46 UTC) #13
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=195432

Powered by Google App Engine
This is Rietveld 408576698